Remove 1.29 checks from CI pipeline#964
Conversation
|
hmm, is there something else we need to do to disable the 1.29 job? |
Kixunil
left a comment
There was a problem hiding this comment.
Other than the version issue this looks great.
.github/workflows/rust.yml
Outdated
There was a problem hiding this comment.
I recommend using 1.41.1 since AFAIR 1.41.0 had miscompilation bugs.
There was a problem hiding this comment.
My bad, that is a mistake. Thanks for noticing.
|
Yes, I need to go into the github UI to disable the 1.29 check. I'll do that as soon as this is merged. +1 to changing to 1.41.1. |
In preparation for starting to merge patches that rely on an MSRV of 1.41 update the CI pipeline.
We no longer need to test Rust 1.29, remove the pinning from the test script.
There was a problem hiding this comment.
ACK 8f45723.
I think we should re-visit all of our dependencies in Cargo.toml to see everything else that we can update. I can see serde_json = "<1.0.45", maybe we can have a later version now?
# We need to pin ryu (transitive dep from serde_json) to stay compatible with Rust 1.22.0
ryu = "<1.0.5"To be clear, we should this in a separate PR afterward.
Good! I had not thought of that. Thanks |
8f45723 test.sh: Remove 1.29 pinning (Tobin C. Harding) 15bae28 Remove CI check for Rust 1.29 (Tobin C. Harding) Pull request description: We no longer need to test against Rust 1.29 now that v0.28 is out. In order to allow minor changes to be merged (i.e., not the _big_ MSRV patchset) that rely on MSRV being 1.41.1 update the CI pipeline. Remove the pinning stuff from `contrib/test.sh` while we are at it. ACKs for top commit: sanket1729: ACK 8f45723. Kixunil: ACK 8f45723 Tree-SHA512: acad2aa75077fd6959b85758aaa2265ae1f9c72a92edb528072cac68e83b903fcd2d15c9410ba35570132d927cf3d0bbc2deb537ba2298958476b0b8e5f2e149
We no longer need to test against Rust 1.29 now that v0.28 is out. In order to allow minor changes to be merged (i.e., not the big MSRV patchset) that rely on MSRV being 1.41.1 update the CI pipeline.
Remove the pinning stuff from
contrib/test.shwhile we are at it.