Merged
Conversation
I think it is more natural to write Wintess::new() followed by Witness::push() then Witness::default(). In any case, there is no harm in having additional constructors.
apoelstra
approved these changes
Jan 11, 2022
Closed
erickcestari
pushed a commit
to erickcestari/rust-bitcoin
that referenced
this pull request
Feb 4, 2026
…oot script and control block sizes 9483366 fix: include varints for Taproot script and control block sizes (Michael Mallan) Pull request description: This is a simple fix for rust-bitcoin#771. ACKs for top commit: apoelstra: ACK 9483366; successfully ran local tests; thanks!! Tree-SHA512: 329406258b83fd0f6e68d1b6f7ea04d3d37b9dacc47809517c584086fb16f74bb4b5f262dd42fc2cc855c298503d681b294bcb9beb263362fa72cb682b4fded1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebasing rust-miniscript on rust-bitcoin master. Expect more trivial PRs :)