Rename inner key field in PrivateKey and PublicKey#762
Rename inner key field in PrivateKey and PublicKey#762sanket1729 merged 1 commit intorust-bitcoin:masterfrom BP-WG:key/inner
Conversation
sanket1729
left a comment
There was a problem hiding this comment.
ffe7ecc47ef6145e11c166cff155afc2acb81bfb. The error is not as bad downstream. Should not be hard for people to debug.
|
61 | println!("{:?}", public_key.key);
| ^^^ unknown field
|
= note: available fields are: `compressed`, `inner`
Kixunil
left a comment
There was a problem hiding this comment.
I'm not certain doing this is a good idea (was avoiding inner word lately) but
ACK ffe7ecc47ef6145e11c166cff155afc2acb81bfb
the code itself. Do as you wish.
|
Rebased |
Kixunil
left a comment
There was a problem hiding this comment.
ACK b7ed6669eba733750a4c8b4ec75f22aa1cdacebf
apoelstra
left a comment
There was a problem hiding this comment.
ACK b7ed6669eba733750a4c8b4ec75f22aa1cdacebf
I like this. Typing key.key everywhere was pretty confusing.
|
Hm, is this ready for the merge? Do not want to merge my own PRs by myself. |
|
Let's wait for one more ACK since @Kixunil was so hesitant. |
|
This will conflict with many of the open PRs. Should we first merge this or merge this as the last PR before the release? What do you think @dr-orlovsky |
|
@sanket1729 lets merge them first, they were much harder and longer to review |
eb09019
|
Now, let's merge this one, after which I will re-base both #696 and #757, which have just a single ACK and have to be re-based anyway now. @apoelstra @sanket1729 @Kixunil pls re-ack |
Since we already broke all possible key-related APIs with this release, I think this one is good to have with 0.28.
Closes #532