WIP: Add Error::Io in order to bubble up write erros to users#713
Closed
tcharding wants to merge 2 commits intorust-bitcoin:masterfrom
Closed
WIP: Add Error::Io in order to bubble up write erros to users#713tcharding wants to merge 2 commits intorust-bitcoin:masterfrom
Error::Io in order to bubble up write erros to users#713tcharding wants to merge 2 commits intorust-bitcoin:masterfrom
Conversation
Add an IO error variant so we can bubble up IO errors.
As a demonstration of usage of the new `Error::Io` bubble up the write error from `concensus_encode` instead of using `unwrap`.
Collaborator
|
You can't fail with a hash engine writes, so here we just have rust |
Collaborator
|
I think we could add some lightweight version of generic |
Member
Author
|
Closing in favour of #719 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a demonstration of one solution to #714. Only required if #714 is deemed to be a real issue.