Skip to content

consensus_encode uses unwrap #714

Closed
#719
Closed
consensus_encode uses unwrap#714
#719
@tcharding

Description

@tcharding
tcharding
opened on Nov 23, 2021

We have many calls to consensus_encode that are followed by unwrap. IIUC consensus_encode can error if the writer errors. Shouldn't we be bubbling theses errors up to users?

Draft PR showing one method of removing unwrap from calls to consensus_encode for WitnessCommitment: #713

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions