tests: improve coverage for P2tr and AddressType#683
Merged
sanket1729 merged 1 commit intorust-bitcoin:masterfrom Nov 16, 2021
Merged
tests: improve coverage for P2tr and AddressType#683sanket1729 merged 1 commit intorust-bitcoin:masterfrom
sanket1729 merged 1 commit intorust-bitcoin:masterfrom
Conversation
36a885e to
11e979c
Compare
11e979c to
8d5a8fd
Compare
dr-orlovsky
previously approved these changes
Nov 12, 2021
Collaborator
dr-orlovsky
left a comment
There was a problem hiding this comment.
utACK 8d5a8fdf8fdc5c64b5fe6e9363dc596ef26b2c41
Collaborator
|
utACK 8d5a8fd |
sanket1729
reviewed
Nov 15, 2021
Member
sanket1729
left a comment
There was a problem hiding this comment.
This won't work because we changed the P2tr API to correctly take in input internal_key instead of output_key.
src/util/address.rs
Outdated
Member
There was a problem hiding this comment.
This should be updated to take in the input internal key instead of the output key. We changed the since #691
Contributor
Author
There was a problem hiding this comment.
Rebased and removed test_p2tr since it was the same as p2tr_from_untweaked, added a couple of lines to the latter
The new AddressType test shows addresses that are valid but have no type. If in the future some of those get a type or become invalid (either voluntarily or due to a regression), this will highlight it.
8d5a8fd to
0d463ec
Compare
Closed
erickcestari
pushed a commit
to erickcestari/rust-bitcoin
that referenced
this pull request
Feb 4, 2026
I royally botched up PR rust-bitcoin#683 which changed fuzzing to run daily, fix it up by doing: - Use the correct yaml file name in `generate-files.sh`. - Actually run `generate-files.sh` to generate the yaml file. - Fix the time UTC comment (the other times were correctly set).
erickcestari
pushed a commit
to erickcestari/rust-bitcoin
that referenced
this pull request
Feb 4, 2026
…z PR bd1df30 Sort fuzz files when finding (Tobin C. Harding) 73d81e5 Follow up from cron-daily-fuzz PR (Tobin C. Harding) Pull request description: I royally botched up PR rust-bitcoin#683 which changed fuzzing to run daily, fix it up by doing: - Use the correct yaml file name in `generate-files.sh`. - Actually run `generate-files.sh` to generate the yaml file. - Fix the time UTC comment (the other times were correctly set). ACKs for top commit: apoelstra: ACK bd1df30 Tree-SHA512: 2af4c030398a79d1de2b2b5d49a399806e21681e5783d97bc139deb6004fed6b34461fb3547070a767d6fff1f76421c775a0a7d1ddc1de05dc50a3d08682618d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new AddressType test shows addresses that are valid but have
no type. If in the future some of those get a type or become
invalid (either voluntarily or due to a regression), this will
highlight it.