Optional feature gives access to Bitcoin Core's own script validator#58
Conversation
|
@apoelstra please review |
|
Can you rebase this and update the README commit to add
Because these are also big breaking changes that will go into 0.12. We may also bring in bech32 support but I'll add that in a separate update to the README. |
|
This is already rebased to current master |
|
Can you rebase this to remove the merge commit and remove the Also to combine the three README-related commits? |
|
@apoelstra would a squash merge not do the same thing? |
|
@tamasblummer There is a merge commit in the PR; a squash merge would prevent an additional merge commit from appearing, but that one is not the one I'm concerned about. |
ae60fea to
755fb45
Compare
|
@apoelstra rebased and squashed |
apoelstra
left a comment
There was a problem hiding this comment.
Heh, ok, that works I guess.
* chore: small import fixes and version bump * chore: moved message verification to feature
* feat: add getrawislocks method * fix: rename query method * feat: add getrawislocks method * fix: rename query method
Adds a feature "bitcoinconsensus" which if enabled links this library with rust-bitcoinconsensus project.
That project wraps Bitcoin Core's own script interpreter for Rust. Use Transaction::verify and Script::verify methods to validate using Bitcoin Core's code.