Change PublicKey::write_into to return Result#507
Merged
apoelstra merged 7 commits intorust-bitcoin:masterfrom Nov 5, 2020
Merged
Change PublicKey::write_into to return Result#507apoelstra merged 7 commits intorust-bitcoin:masterfrom
apoelstra merged 7 commits intorust-bitcoin:masterfrom
Conversation
This is just a sanity check on our own serialization code.
apoelstra
approved these changes
Nov 5, 2020
yancyribbens
pushed a commit
to yancyribbens/rust-bitcoin
that referenced
this pull request
Mar 23, 2024
yancyribbens
pushed a commit
to yancyribbens/rust-bitcoin
that referenced
this pull request
Mar 23, 2024
…coin#507 f0f7fd6 fix formatting after rust-bitcoin#507 (Andrew Poelstra) Pull request description: I merged rust-bitcoin#507 without checking CI, and it turns out there was a rustfmt issue. FIx that. ACKs for top commit: tcharding: ACK f0f7fd6 sanket1729: ACK f0f7fd6 Tree-SHA512: 909d0a118c0e36f40b7aa6f0d6c7718b1b77b00acbb07ae0183a26e107a24f477debebc701545a8295a31dc589b9f40174a44a0c6e935ecab445c447078c3784
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup on #506.