hashes: Add an api test module#4017
Conversation
|
🚨 API BREAKING CHANGE DETECTED To see the changes click details on "Check semver breaks / PR Semver - stable toolchain" job then expand "Run semver checker script" and scroll to the end of the section. |
ffe6afe to
b3bb8d0
Compare
|
🚨 API BREAKING CHANGE DETECTED To see the changes click details on "Check semver breaks / PR Semver - stable toolchain" job then expand "Run semver checker script" and scroll to the end of the section. |
b3bb8d0 to
1ae7a57
Compare
|
🚨 API BREAKING CHANGE DETECTED To see the changes click details on "Check semver breaks / PR Semver - stable toolchain" job then expand "Run semver checker script" and scroll to the end of the section. |
|
Win for the API breaking bot - I botched this, it should not have API changes mixed into a single patch. Will fix tomorrrow. |
1ae7a57 to
b570f8b
Compare
b570f8b to
9fd09bf
Compare
|
🚨 API BREAKING CHANGE DETECTED To see the changes click details on "Check semver breaks / PR Semver - stable toolchain" job then expand "Run semver checker script" and scroll to the end of the section. |
|
Note to self, the PRs on which this is based have changed. Be careful when rebasing. Hey @apoelstra, @Kixunil, @jamillambert - are these comments I write to myself annoying when they show up in your notifications? |
|
I usually ignore drafts. It's a random chance that I even looked at this one. |
|
I don't mind. If you hadn't mentioned me I would only see them when I was in the mood to look through the PR and probably find them helpful to see the status of it. |
|
TL;DR I don't mind. Once my local CI box has a few hours of work queued up then I start looking at issues and drafts, since those can be moved out of my notifications and open tabs without waiting for the CI box. Usually with drafts I don't even look at the code, on the assumption that I'll get a notification later when it gets undrafted or when somebody specifically asks me to look at the code. |
|
Mad, cheers. |
9fd09bf to
2421cf4
Compare
In preparation for 1.0-ing `primitives` add an `api` test module that makes an effort to verify the API surface. This is similar to what is in `units` and what is in development for `hashes` (in rust-bitcoin#4017).
In preparation for 1.0-ing `primitives` add an `api` test module that makes an effort to verify the API surface. This is similar to what is in `units` and what is in development for `hashes` (in rust-bitcoin#4017).
|
O boy, if we are considering doing #4051 then this trait bound discussion is a waste of clock cycles. Removing the patch and requesting merge of this as is. I'll amend the FIXME to a plain comment. |
4ee52bd to
9c23ec6
Compare
|
Lets let #4085 go in first. |
In preparation for 1.0-ing `primitives` add an `api` test module that makes an effort to verify the API surface. This is similar to what is in `units` and what is in development for `hashes` (in rust-bitcoin#4017).
9c23ec6 to
926b061
Compare
|
🚨 API BREAKING CHANGE DETECTED To see the changes click details on "Check semver breaks / PR Semver - stable toolchain" job then expand "Run semver checker script" and scroll to the end of the section. |
In preparation for 1.0-ing `primitives` add an `api` test module that makes an effort to verify the API surface. This is similar to what is in `units` and what is in development for `hashes` (in rust-bitcoin#4017).
In preparation for 1.0-ing `primitives` add an `api` test module that makes an effort to verify the API surface. This is similar to what is in `units` and what is in development for `hashes` (in rust-bitcoin#4017).
In preparation for 1.0-ing `primitives` add an `api` test module that makes an effort to verify the API surface. This is similar to what is in `units` and what is in development for `hashes` (in rust-bitcoin#4017).
As we did for `units` and as part of the stabalization effort. Add an `api` test module that verifies the public API for the `hashes` crate.
926b061 to
f268ca2
Compare
In preparation for 1.0-ing `primitives` add an `api` test module that makes an effort to verify the API surface. This is similar to what is in `units` and what is in development for `hashes` (in rust-bitcoin#4017).
In preparation for 1.0-ing `primitives` add an `api` test module that makes an effort to verify the API surface. This is similar to what is in `units` and what is in development for `hashes` (in rust-bitcoin#4017).
|
Looks good! It does make me think that maybe we can implement Maybe better to wait for somebody to show up with a usecase and we can add stuff then.. |
|
Shameless bump. |
In preparation for 1.0-ing `primitives` add an `api` test module that makes an effort to verify the API surface. This is similar to what is in `units` and what is in development for `hashes` (in rust-bitcoin#4017).
In preparation for 1.0-ing `primitives` add an `api` test module that makes an effort to verify the API surface. This is similar to what is in `units` and what is in development for `hashes` (in rust-bitcoin#4017).
e2d9a8a primitives: Add an API test module (Tobin C. Harding) 8ec2d35 primitives: Derive Clone on witness::Iter (Tobin C. Harding) Pull request description: In preparation for 1.0-ing `primitives` add an `api` test module that makes an effort to verify the API surface. This is similar to what is in `units` and what is in development for `hashes` (in #4017). Note, there is a WIP attempt at this in #3992. Close: #3928 ACKs for top commit: apoelstra: ACK e2d9a8a; successfully ran local tests Tree-SHA512: 5ec5c87c9aa5e86e579283a5485dcb2b3b5ae59359ae5ab96f8e6634285072bef0d0f111b6780852fd88fe29677f1a84c791a3343a0cb2b09093e77125f3962b
As we did for
unitsand as part of the stabalization effort.Add an
apitest module that verifies the public API for thehashescrate.Close: #3927