Remove unnecessary panic from from_int_btc_const#3932
Closed
shinghim wants to merge 1 commit intorust-bitcoin:masterfrom
Closed
Remove unnecessary panic from from_int_btc_const#3932shinghim wants to merge 1 commit intorust-bitcoin:masterfrom
from_int_btc_const#3932shinghim wants to merge 1 commit intorust-bitcoin:masterfrom
Conversation
Pull Request Test Coverage Report for Build 12861190692Details
💛 - Coveralls |
tcharding
added a commit
to tcharding/rust-bitcoin
that referenced
this pull request
Jan 20, 2025
In preparation for release add a changelog entry, bump the version, and update the lock files. `v1.0` here we come. Before we merge this we should add: - rust-bitcoin#3934 or rust-bitcoin#3866 - rust-bitcoin#3933 - rust-bitcoin#3932 - rust-bitcoin#3929 - rust-bitcoin#3926 - rust-bitcoin#3923 - rust-bitcoin#3893 - rust-bitcoin#3866 - rust-bitcoin#3794
tcharding
approved these changes
Jan 20, 2025
Member
|
I'm happy to merge this but it is made redundant by #3794 - I could have thought that through more fully before raising the PR. |
Member
|
Thanks @shinghim! |
| Some(amount) => Amount::from_sat(amount), | ||
| None => panic!("checked_mul overflowed"), | ||
| } | ||
| Amount(btc * 100_000_000) // Don't need checked multiplication: u32::MAX * 100_000_000 < u64::MAX |
Contributor
There was a problem hiding this comment.
shouldn't the comment say < MAX_MONEY instead of < u64::MAX? Which it's not..
Member
There was a problem hiding this comment.
Currently the unsigned module is not enforcing the MAX_MONEY invariant.
Member
|
Merge merge merge. Part of #3935 - LFG! |
Member
|
Oh, sorry, I've been ignoring this because you said it was obsoleted by #3794 which I haven't reviewed yet. |
Member
|
woops, I just saw that I'd acked it and it was on the list. |
Member
|
Lets just close. @shinghim hope that is ok with you. |
Contributor
Author
|
Good with me 👍🏼 |
tcharding
added a commit
to tcharding/rust-bitcoin
that referenced
this pull request
Feb 24, 2025
We are trying a new strategy to get to 1.0 more quickly - remove `amount` and `fee` and release everything else. In preparation for release add a changelog entry, bump the version, and update the lock files. `v1.0` here we come. Before we merge this we should add: - rust-bitcoin#3934 or rust-bitcoin#3866 - rust-bitcoin#3933 - rust-bitcoin#3932 - rust-bitcoin#3929 - rust-bitcoin#3926 - rust-bitcoin#3923 - rust-bitcoin#3893 - rust-bitcoin#3866 - rust-bitcoin#3794
tcharding
added a commit
to tcharding/rust-bitcoin
that referenced
this pull request
Feb 24, 2025
We are trying a new strategy to get to 1.0 more quickly - remove `amount` and `fee` and release everything else. In preparation for release add a changelog entry, bump the version, and update the lock files. `v1.0` here we come. Before we merge this we should add: - rust-bitcoin#3934 or rust-bitcoin#3866 - rust-bitcoin#3933 - rust-bitcoin#3932 - rust-bitcoin#3929 - rust-bitcoin#3926 - rust-bitcoin#3923 - rust-bitcoin#3893 - rust-bitcoin#3866 - rust-bitcoin#3794
tcharding
added a commit
to tcharding/rust-bitcoin
that referenced
this pull request
Feb 24, 2025
We are trying a new strategy to get to 1.0 more quickly - remove `amount` and `fee` and release everything else. In preparation for release add a changelog entry, bump the version, and update the lock files. `v1.0` here we come. Before we merge this we should add: - rust-bitcoin#3934 or rust-bitcoin#3866 - rust-bitcoin#3933 - rust-bitcoin#3932 - rust-bitcoin#3929 - rust-bitcoin#3926 - rust-bitcoin#3923 - rust-bitcoin#3893 - rust-bitcoin#3866 - rust-bitcoin#3794
tcharding
added a commit
to tcharding/rust-bitcoin
that referenced
this pull request
Feb 24, 2025
We are trying a new strategy to get to 1.0 more quickly - remove `amount` and `fee` and release everything else. In preparation for release add a changelog entry, bump the version, and update the lock files. `v1.0` here we come. Before we merge this we should add: - rust-bitcoin#3934 or rust-bitcoin#3866 - rust-bitcoin#3933 - rust-bitcoin#3932 - rust-bitcoin#3929 - rust-bitcoin#3926 - rust-bitcoin#3923 - rust-bitcoin#3893 - rust-bitcoin#3866 - rust-bitcoin#3794
tcharding
added a commit
to tcharding/rust-bitcoin
that referenced
this pull request
Feb 24, 2025
We are trying a new strategy to get to 1.0 more quickly - remove `amount` and `fee` and release everything else. In preparation for release add a changelog entry, bump the version, and update the lock files. `v1.0` here we come. Before we merge this we should add: - rust-bitcoin#3934 or rust-bitcoin#3866 - rust-bitcoin#3933 - rust-bitcoin#3932 - rust-bitcoin#3929 - rust-bitcoin#3926 - rust-bitcoin#3923 - rust-bitcoin#3893 - rust-bitcoin#3866 - rust-bitcoin#3794
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3779