Skip to content

Feature/issue 350#360

Merged
apoelstra merged 2 commits intorust-bitcoin:masterfrom
kiminuo:feature/issue-350
Dec 10, 2019
Merged

Feature/issue 350#360
apoelstra merged 2 commits intorust-bitcoin:masterfrom
kiminuo:feature/issue-350

Conversation

@kiminuo
Copy link
Copy Markdown
Contributor

@kiminuo kiminuo commented Dec 8, 2019 •
edited
Loading

Tested on Windows, using:

git clone --single-branch --branch feature/issue-350 https://github.com/kiminuo/rust-bitcoin.git
Cloning into 'rust-bitcoin'...
remote: Enumerating objects: 69, done.
remote: Counting objects: 100% (69/69), done.
remote: Compressing objects: 100% (50/50), done.
remote: Total 5325 (delta 28), reused 31 (delta 13), pack-reused 5256
Receiving objects: 100% (5325/5325), 2.18 MiB | 2.41 MiB/s, done.
Resolving deltas: 100% (3412/3412), done.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 8, 2019

Codecov Report

Merging #360 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #360   +/-   ##
=======================================
  Coverage   82.49%   82.49%           
=======================================
  Files          39       39           
  Lines        7850     7850           
=======================================
  Hits         6476     6476           
  Misses       1374     1374

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8547182...d8223bb. Read the comment docs.

@TheBlueMatt
Copy link
Copy Markdown
Member

TheBlueMatt commented Dec 8, 2019

travis-fuzz isnt whats used to generate the fuzz outputs, though it may be useful to have a contrib/rename-fuzz-files.sh file that can be installed as a git pre-commit hook.

@kiminuo
Copy link
Copy Markdown
Contributor Author

kiminuo commented Dec 8, 2019

@TheBlueMatt I know. The idea was that travis-fuzz.sh would reveal that newly added/modified fuzz inputs will cause trouble for Windows users.

I'm open to make changes.

TheBlueMatt
TheBlueMatt approved these changes Dec 8, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I'm sorry, I didn't read close enough. Looks good.

apoelstra
apoelstra approved these changes Dec 10, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@apoelstra apoelstra merged commit f6f4ea7 into rust-bitcoin:master Dec 10, 2019
@dr-orlovsky dr-orlovsky mentioned this pull request Jan 6, 2022
Merged
@RCasatta RCasatta mentioned this pull request Oct 6, 2022
Closed
PastaPastaPasta pushed a commit to PastaPastaPasta/rust-dashcore that referenced this pull request Feb 2, 2026
@QuantumExplorer
feat: add wallet_manager_network FFI function (rust-bitcoin#360)
fe72e44 
* feat: add FFI account creation options and network retrieval function

* fix

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheBlueMatt TheBlueMatt TheBlueMatt approved these changes

@apoelstra apoelstra apoelstra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kiminuo @codecov-io @TheBlueMatt @apoelstra