Create empty bitcoin-addresses crate#2928
Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom Jul 1, 2024
Merged
Conversation
Member
Author
|
Alternative to #2898 |
f56ed59 to
b0f795c
Compare
Kixunil
previously approved these changes
Jun 27, 2024
Collaborator
Kixunil
left a comment
There was a problem hiding this comment.
ACK b0f795cb03d60b730d24315e87ecd8d7c6033c61
Member
|
Sorry, was procrastinating on this and now it needs rebase. |
We intend on splitting the address types and logic out into a separate crate. In preparation for doing so, and so that we can grab the name on crates.io, add an empty crate `bitcoin-addresses`. Tie it in to the CI infrastructure.
b0f795c to
0630457
Compare
Member
Author
|
Woops, wrong PR to close. |
Kixunil
approved these changes
Jun 29, 2024
Kixunil
approved these changes
Jun 29, 2024
Member
|
Tagged and published. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We intend on splitting the address types and logic out into a separate crate. In preparation for doing so, and so that we can grab the name on crates.io, add an empty crate
bitcoin-addresses.Tie it in to the CI infrastructure excluding the
check-apiinfrastructure because that is in flux.