Create empty bitcoin-receive crate#2898
Create empty bitcoin-receive crate#2898tcharding wants to merge 1 commit intorust-bitcoin:masterfrom
bitcoin-receive crate#2898Conversation
bitcoin-receive crate
|
If/when this merges can you please publish to crates.io @apoelstra, I ran |
We intend on splitting the address types and logic out into a separate crate. In preparation for doing so, and so that we can grab the name on crates.io, add an empty crate `bitcoin-receive`. Tie it in to the CI infrastructure.
c6936d0 to
a7fbca0
Compare
|
|
|
Yep |
|
That's a really sad name that doesn't suggest it's an address at all. I wish crate-based namespaces were a thing already... |
I agree. When I stumbled upon this PR and seeing the title, I thought it was something P2P related. use bitcoin_address::Foowhich conveys the message even for newcomers into Rust and/or bitcoin. |
Somebody already had bitcoin-address: #2883 (comment) |
|
The least bad name I can think of is |
|
I'm down with that name, its nice also because of the other plurals |
|
Today's triggering is free of charge, you're welcome :) |
|
Well everyone in this industry treat the term "bitcoin" different. |
|
Oh yeah, I've just realized we have two address types so the plural is appropriate: |
|
An alternative to this that uses the crate name |
|
Yeah, agreed with the above, let's go with |
|
I am a tiny bit worried about the existing unmaintained |
We intend on splitting the address types and logic out into a separate crate. In preparation for doing so, and so that we can grab the name on crates.io, add an empty crate
bitcoin-receive.Tie it in to the CI infrastructure.