Allow m prefix in derivation paths#2677
Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom Apr 15, 2024
Merged
Conversation
Recently in rust-bitcoin#2451 we disallowed bip32 derivation paths with the leading 'm' variable. There is some confusion as to what exactly the bip specifies however Bitcoin Core RPC call `getaddressinfo` returns a derivation path with a leading "m/". This means we need to be able to parse it irrespective of what the bip says. Be more liberal in what we accept as a derivation path, including both with and without the leading 'm/'. Leave the full investigation of the bip to a later date. Change back some of the test strings as makes sense and include test strings to showcase the full current behaviour.
Pull Request Test Coverage Report for Build 8638018440Details
💛 - Coveralls |
apoelstra
approved these changes
Apr 11, 2024
Member
|
cc @sanket1729 could you take a look and ACK this? I believe this is the only issue with our first rc, so if we can merge this (and backport it) we can release another. |
Member
Author
We have the other two trivial ones too, but you are correct in that this PR has the only code change: https://github.com/rust-bitcoin/rust-bitcoin/pulls?q=+is%3Apr+label%3Aport-0.32.x+ |
junderw
approved these changes
Apr 15, 2024
apoelstra
added a commit
that referenced
this pull request
Apr 17, 2024
b7f61e2 Allow m prefix in derivation paths (Tobin C. Harding) Pull request description: This PR contains a single patch that was created using `cargo cherry-pick 830c1e9` - i.e., it is a backport of #2677. ---- Recently in #2451 we disallowed bip32 derivation paths with the leading 'm' variable. There is some confusion as to what exactly the bip specifies however Bitcoin Core RPC call `getaddressinfo` returns a derivation path with a leading "m/". This means we need to be able to parse it irrespective of what the bip says. Be more liberal in what we accept as a derivation path, including both with and without the leading 'm/'. Leave the full investigation of the bip to a later date. Change back some of the test strings as makes sense and include test strings to showcase the full current behaviour. ACKs for top commit: apoelstra: ACK b7f61e2 confirmed that diff exactly matches 2451. CI failure is unrelated. Tree-SHA512: 075e8a7d368dd216f947954459f67812b248982b5e022ac158e1022d8adcb7ce603f63951385fb88c397a66305e1cb3a25c89fdf4726bddc1fa1e2d190950f41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently in #2451 we disallowed bip32 derivation paths with the leading 'm' variable.
There is some confusion as to what exactly the bip specifies however Bitcoin Core RPC call
getaddressinforeturns a derivation path with a leading "m/". This means we need to be able to parse it irrespective of what the bip says.Be more liberal in what we accept as a derivation path, including both with and without the leading 'm/'.
Leave the full investigation of the bip to a later date.
Change back some of the test strings as makes sense and include test strings to showcase the full current behaviour.
This PR replaces #2674.