Skip to content

Bump bitcoin-bech32 dependency#244

Merged
dongcarl merged 1 commit intorust-bitcoin:masterfrom
stevenroose:bech32-bump
Mar 7, 2019
Merged

Bump bitcoin-bech32 dependency#244
dongcarl merged 1 commit intorust-bitcoin:masterfrom
stevenroose:bech32-bump

Conversation

@stevenroose
Copy link
Copy Markdown
Collaborator

This makes the Address::Payload::WitnessProgram inner type compatiblewith rust-lightning-invoice's Fallback::SegWitProgram's inner type.
This allows specifying fallbacks from addresses.

@stevenroose stevenroose requested a review from sgeisler March 4, 2019 21:13
This makes the Address::Payload::WitnessProgram inner type compatible
with rust-lightning-invoice's Fallback::SegWitProgram's inner type.
This allows specifying fallbacks from addresses.
@sgeisler sgeisler added the API break This PR requires a version bump for the next release label Mar 6, 2019
Copy link
Copy Markdown
Contributor

@sgeisler sgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good idea, I hope that the types will converge more over time, but I have to plan how to do that without having too much duplicated data ("cached" bech32 representation).

@dongcarl dongcarl merged commit d667e0f into rust-bitcoin:master Mar 7, 2019
casey pushed a commit to casey/rust-bitcoin that referenced this pull request Nov 28, 2023
yancyribbens pushed a commit to yancyribbens/rust-bitcoin that referenced this pull request Mar 23, 2024
miniscript: remove a redundant check for non-ASCII chars
PastaPastaPasta pushed a commit to PastaPastaPasta/rust-dashcore that referenced this pull request Feb 2, 2026
* segments cache struct and evict method generalized

* save segments to disk made generic inside the segments cache struct

* save_dirty_segments logic refactorized

* tbh I dont know waht I refactored here

* removed io module inside storage/disk

* you are right rabbit

* store in segment moved to SegmentCache

* sentinel headers creation moved to the Persistable trait and encapsulated there

* unified sentinel item behaviour - no longer compiles bcs the tip_high calculation

* renames

* new struct to manage the hashmap of segments and tip height moved - doesnt compile yet, wip

* get_headers generalized in the SegmentsCache struct - wip, not compiles

* store headers logic moved to the SegmentsCache and introduced method to better handle tip_height and storage index - wip, no compiles

* store_headers_impl using precomputed_hashes didn't provide real benefics with the current usage - wip, no compiles

* removed unused StorageManager::get_headers_batch methos - wip, no compiles

* removed warnings

* ensure segment loaded moved inside the SegmentsCache with a logic change, we ask for a segment and if it doesn't exist in memory we load it from disk - wip, no compiles

* const MAX_ACTIVE_SEGMENTS encapsulated - wip, no compiles

* removed one commit as it is fixed

* created a SegmentsCache::store_headers_at_height - wip, no compiles

* removed inconsistency when loading segments metadata

* removed to methods unused bcs now that behaviour is encapsulated

* building SegmentCache yip_height when creating the struct

* removed unused function

* some refactor and removed the notification enum and related behaviour - wip, no compiles

* disk storage manager worker no longer needs cloned headers to work

* renamed segments stoage fields

* removed new unused function

* evict logic removed

* save dirty segments logic moved into SegmentsCache

* clippy warnings fixed

* save dirty is now an instance method for the DiskStorageManager

* when persisting segments we try to create the parent dirs to ensure they exist

* improved logic to ensure different clear behaviour for SegmentsCache

* correctly rebuilding the block reverse index

* fixed bug found by test test_checkpoint_storage_indexing

* fixed bug updating tip_height in SegmentCache thanks spotted by test test_filter_header_segments

* fixed bug, we stop persisting segments after we find the first sentinel, to correctly initialize valid_count - bug spotted by test test_filter_header_persistence

* refactor: HEADER_PER_SEGMENT encapsulated inside segment and renamed to ITEMS_PER_SEGMENT - wip, no compiles

* block index rebuild logic moved into SegmentCache<BlockHeader> and load_segment_metadata renamed in flavor of a better name for its current behaviour being the block index contructor

* added some cool inlines

* fixed test that was creating a centinel filter header at height 0 making the segment not persist entirely

* renamed header reference to item in segments.rs so its clear that the new struct can work with any struct

* clippy warning fixed

* logging when storing multiple items simplified

* removed sentinel headers from the segments logic

* unit tests for the segment and segment_cache structs after the refactor (rust-bitcoin#259)

* removed unused methods after rebase

* renamed and removed old documentation for store_headers_impl

* refactorized and adjusted docs for conversion methods between stoage index, height and offset

* removed old comments and forcing to give sync_base_height when creating the SegmentCache

* quick fix to load sync_base_height if persisted before

* review comments addressed

* read block index operation made async

* using atomic write where we write to disk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API break This PR requires a version bump for the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants