INCOMPLETE DEMO - DO NOT MERGE: Split up CI tasks and unify test scripts#2343
Closed
Kixunil wants to merge 2 commits intorust-bitcoin:masterfrom
Closed
INCOMPLETE DEMO - DO NOT MERGE: Split up CI tasks and unify test scripts#2343Kixunil wants to merge 2 commits intorust-bitcoin:masterfrom
Kixunil wants to merge 2 commits intorust-bitcoin:masterfrom
Conversation
This was originally related to coverate which we don't do now.
Closed
ebfefb4 to
aa5ff6a
Compare
I started doing this and then I found Tobin is doing the same thing, so I stopped. This is INCOMPLETE and UNTESTED. Things that I would do if I continued: * Delete `contrib/*/test.sh` * Add `contrib/*/test_vars.sh` * Test and fix any outstanding bugs
aa5ff6a to
7ca2a8e
Compare
Collaborator
Author
|
I've fixed at least the Prepare job which is the hard part so that a working solution to generate the matrix can be demonstrated. |
Member
|
Legend, thanks - leave it with me. |
Collaborator
Author
|
Forgot to point out that this implements single source of truth for crates, so no more adding of new crates to a bunch of places. (IME SSOT is super-important in programming.) |
Member
|
I agree wholeheartedly, except on the name, I always call it Single Point Of Truth (SPOT) :) |
Merged
Member
|
Closing in favour of #2353 |
apoelstra
added a commit
that referenced
this pull request
Feb 2, 2024
01a66a7 CI: Check for required commands (Tobin C. Harding) 5c15ed5 CI: Epic overhaul (Martin Habovstiak) 242aa67 Use env bash instead of /bin/bash (Tobin C. Harding) 422d301 Use bash to run shell scripts (Tobin C. Harding) Pull request description: The combination of some work by myself [0] and Kix [1]. Draft so I can use github's infrastructure to test it all out. Includes some patches at the front to fix real issues that the new test infrastructure found - WIN. [0] #2328 [1] #2343 Coincidentally this closes 1124 Resolve: #1124 ACKs for top commit: apoelstra: ACK 01a66a7 Tree-SHA512: 026a0948a181102246702eadc3ff245c319c456b03ada9ca269141d006146f30fd8eb50377062735a06c3e369f7edac2e334587120338a3747810d999177d930
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started doing this and then I found Tobin is doing the same thing, so
I stopped. This is INCOMPLETE and UNTESTED. Things that I would do if I
continued:
contrib/*/test.shcontrib/*/test_vars.sh