bip32: Add DerivationPath type#233
Merged
dongcarl merged 4 commits intorust-bitcoin:masterfrom Feb 15, 2019
Merged
Conversation
Member
|
@stevenroose Could you force push again? I think Travis is buggy. |
dongcarl
reviewed
Feb 11, 2019
Member
|
Possible followup PR: Implement |
Contributor
Here it might even make sense to implement the different index/range traits, so you could select sub-paths: let first_key = DerivationPath::from_str("m/84'/0'/0'/0/0")?;
let next_key = first_key[..4].child(first_key[4] + 1); |
94d33c4 to
15ab50c
Compare
sgeisler
suggested changes
Feb 12, 2019
15ab50c to
745481d
Compare
stevenroose
commented
Feb 13, 2019
sgeisler
reviewed
Feb 13, 2019
sgeisler
reviewed
Feb 13, 2019
They can produce an error if the index is out of range.
Implements Display and FromStr for easy usage with serialized types.
745481d to
dce81b6
Compare
- From<&[ChildNumber]> (cloning) - AsRef<[ChildNumber]> - std::iter::FromIterator<ChildNumber> - std::iter::IntoIterator<ChildNumber> - std::ops::Index (returning &[ChildNumber]) Also add two methods: - child(&self, ChildNumber) -> DerivationPath - into_child(self, ChildNumber) -> DerivationPath
sgeisler
approved these changes
Feb 14, 2019
Contributor
sgeisler
left a comment
There was a problem hiding this comment.
Addressed all comments, LGTM.
yancyribbens
pushed a commit
to yancyribbens/rust-bitcoin
that referenced
this pull request
Mar 23, 2024
Explicitly error on non-standard sighash types
PastaPastaPasta
pushed a commit
to PastaPastaPasta/rust-dashcore
that referenced
this pull request
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #185.