Skip to content

Increase version to 0.15#188

Merged
apoelstra merged 2 commits intorust-bitcoin:masterfrom
apoelstra:2018-11-0.15
Nov 7, 2018
Merged

Increase version to 0.15#188
apoelstra merged 2 commits intorust-bitcoin:masterfrom
apoelstra:2018-11-0.15

Conversation

@apoelstra
Copy link
Copy Markdown
Member

No description provided.

@stevenroose
Copy link
Copy Markdown
Collaborator

stevenroose commented Nov 6, 2018

ACK
Would be very welcome tbh since literally all code I made in Rust was based on post-latest-release master :)

@apoelstra apoelstra merged commit 7d7c360 into rust-bitcoin:master Nov 7, 2018
@apoelstra apoelstra deleted the 2018-11-0.15 branch November 7, 2018 16:38
yancyribbens pushed a commit to yancyribbens/rust-bitcoin that referenced this pull request Mar 23, 2024
PastaPastaPasta pushed a commit to PastaPastaPasta/rust-dashcore that referenced this pull request Feb 2, 2026
PastaPastaPasta pushed a commit to PastaPastaPasta/rust-dashcore that referenced this pull request Feb 2, 2026
…-bitcoin#197)

* feat(spv): flush headers on shutdown

* move fn lower in the impl

* refactor: `MultiPeerNetworkManager` -> `PeerNetworkManager` (rust-bitcoin#184)

* refactor: `MultiPeerNetworkManager` -> `PeerNetworkManager`

* Fix formatting and apply review

* feat: Update ffi headers (rust-bitcoin#183)

* feat(spv): broadcast transaction (rust-bitcoin#180)

* fix: Fix `PeerNetworkManager` cast in `broadcast_transaction` (rust-bitcoin#185)

PR rust-bitcoin#180 used `MultiPeerNetworkManager`, this was renamed in rust-bitcoin#183 which was merged before rust-bitcoin#180 but after its CI run.

* fix: Use non-blocking `TcpStream` in `dash-spv::network::TcpConnection` (rust-bitcoin#188)

* refactor: Improve SPV shutdown handling with `CancellationToken` (rust-bitcoin#187)

* refactor: `TcpConnection` -> `Peer` and `ConnectionPool` -> `PeerPool` (rust-bitcoin#190)

* fix: Locking issue after rust-bitcoin#190 (rust-bitcoin#191)

rust-bitcoin#190 removed the read timeouts of the `Peer::receive_message` which currently leads to a lockup of the peer because the write lock is held while waiting for the message. Needs some more refactoring but this works for now.

* fix: More follow-up to rust-bitcoin#190 (rust-bitcoin#193)

The sleep timeout branch introduced in rust-bitcoin#191 returns an `Err(NetworkError::Timeout)` which leads to a misbehavior update below in the `msg_result` match and eventually in a peer ban. This shouldn't happen because the `sleep` timing out only means that there is no data available right now. Instead, it now returns `Ok(None)` which will just keep things going.

* flush after mn list sync too

* move flush to after header sync instead of mnlist

* fix

---------

Co-authored-by: Kevin Rombach <35775977+xdustinface@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants