transaction: Add doc alias is_coinbase to is_coin_base method#1795
Closed
stevenroose wants to merge 1 commit intorust-bitcoin:masterfrom
Closed
transaction: Add doc alias is_coinbase to is_coin_base method#1795stevenroose wants to merge 1 commit intorust-bitcoin:masterfrom
stevenroose wants to merge 1 commit intorust-bitcoin:masterfrom
Conversation
Member
|
I think we should deprecate and rename. |
Collaborator
Author
|
Well, let's keep both options open and see: I'm also more in favor of renaming. |
Collaborator
|
WTF, I'd swear we did already rename it. |
Collaborator
Author
|
Clippy... I'll go with 0.0.0-NEXT_RELEASE |
Collaborator
Author
In rust-elements it's |
Member
|
ha, when I read the PR title I literally thought "that's weird, why would there be a function called |
apoelstra
added a commit
that referenced
this pull request
Apr 24, 2023
a54e1ce Apply rustfmt (The rustfmt Tyranny) 38d11ce ci: Make release CI search for NEXT.RELEASE instead (Steven Roose) dad3abd transaction: Rename is_coin_base to is_coinbase (Steven Roose) Pull request description: Alternative to #1795. Keep the old method as deprecated and add doc alias. Also change internal usage of the method. ACKs for top commit: tcharding: ACK a54e1ce apoelstra: ACK a54e1ce Tree-SHA512: 52d9729bf83da164556d960f8867cb836ff57a0f619da3dd3620efffb28a974aac23b8085863ab0e072a4bdb2f13ac576efa43ad2eec9a271ad044227f4d00a4
Member
|
We can close this now since #1796 merged, right? |
Collaborator
|
Yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It has officially been two times in two years that I remember thinking "heh, I really thought there was an is_coinbase method, but I guess I was wrong" to then later find it in the code.
This is just a doc alias so that searching for the method (and grepping the code!) will give you a result for is_coinbase.
Tbh, I'd be in favor of deprecating the method and renaming it as well, but well. I've never seen anyone write "coin base transaction" or "coin-base transaction", always just "coinbase transaction". But for the sake of stability, I like the doc alias.