Move sighash module to crate root#1340
Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom Oct 25, 2022
Merged
Conversation
Done as part of the effort to flatten the `util` module. The `sighash` module can stand alone in the crate root, it provides a discreet set of functionality - the `SighashCache` and associated types.
Member
Author
|
I wasn't sure if the concept of moving was trivial, the patch is definitely trivial :) |
Collaborator
|
It's supposed to mean "trivial to review" which it should be - only |
apoelstra
approved these changes
Oct 25, 2022
apoelstra
added a commit
to apoelstra/rust-bitcoin
that referenced
this pull request
Oct 25, 2022
…itcoin#999 I will test merge commits more thoroughly before signing off on them in future, sorry.
sanket1729
added a commit
that referenced
this pull request
Oct 27, 2022
c4084b9 Fix broken build due to conflict between #1340 and #999 (Andrew Poelstra) Pull request description: I will test merge commits more thoroughly before signing off on them in future, sorry. ACKs for top commit: DanGould: tACK c4084b9 tcharding: ACK c4084b9 sanket1729: ACK c4084b9 Tree-SHA512: 51ece3aa43045e81138d21b8402b1ec1559a0b37bdfc4c5246ff46fd085364517449a2e20e625934cbc0c96f18eb2fc6121a6e993fd5b9535ae54c863d032a0b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done as part of the effort to flatten the
utilmodule.The
sighashmodule can stand alone in the crate root, it provides a discreet set of functionality - theSighashCacheand associated types.Marking as high priority because this is part of flattening
utilwhich is a required step before we start crate smashing.