Add ci check for duplicate dependencies#1114
Conversation
Kixunil
left a comment
There was a problem hiding this comment.
ACK 521b119720d66d1298a0228b1a514578c8079af7
I don't mind re-reviewing if you quote the variable. :)
contrib/test.sh
Outdated
There was a problem hiding this comment.
Bash paranoia mindset says you should put double quotes around variables (unless intentional). In this case if wc screwed up and printed a space. (Unlikely but a good habit.)
There was a problem hiding this comment.
Sure thing, can do. Cheers.
|
I don't know how much does this check add to the actions time, but possibly it could be a part of a different workflow - eg. one running every 24 hours. It's not exactly critical or urgent to fix these. |
|
@dpc on my machine with bunch of browser tabs spinning CPU |
Add a call to `cargo tree --duplicates` in the ci script to ensure that we do not have any duplicated dependencies. Kudos to Martin for the idea.
521b119 to
cda097d
Compare
|
Changes in force push: Add quotes around variable as suggested, no other changes. |
|
BTW for shellscript, I recommend to always use a |
BOOM! |
|
I ran |
…ndencies cda097d Add ci check for duplicate dependencies (Tobin C. Harding) Pull request description: Add a call to `cargo tree --duplicates` in the ci script to ensure that we do not have any duplicated dependencies. Kudos to Kixunil for the idea (over in: rust-bitcoin/rust-bitcoin#1104) ACKs for top commit: apoelstra: ACK cda097d Kixunil: ACK cda097d Tree-SHA512: 77f07dd5c6794b5a59293bd62bda0fe61384a30cf8258e79aca9ce32090f869f0a13929b6a7a4c35e10fc653968b12ddd4c291df9ecd0962632017f59c81d025
Add a call to
cargo tree --duplicatesin the ci script to ensure that we do not have any duplicated dependencies.Kudos to Kixunil for the idea (over in: #1104)