[code hygiene] remove deprecated rustc-serialize#107
[code hygiene] remove deprecated rustc-serialize#107apoelstra merged 1 commit intorust-bitcoin:masterfrom savil:remove-rustc-serialize
Conversation
|
Otherwise: ACK |
|
fixed the hex-dependency to a specific commit-hash, as requested. I don't have strong opinions on this issue. in IRC, @dongcarl said that its more reliable that version-numbers since some package managers can change the code despite the version number being the same. I will note that in Cargo.toml, other dependencies all use version numbers. shrugs |
|
Pasting dependency discussion from IRC: <BlueMatt> andytoshi: heh, I mean I guess pinning a dep for hex is ok, though given its use in like only one place (and only serialize!) in non-test, you could really make it a test-only dep and add the written out hex encoder in the one place its used It may be out of scope to do the serde-optional thing in this PR, but would be super, super nice to make that happen IMO. |
|
I'll look into making it test-only tomorrow |
|
I think we should leave the hex dependency for now. I'll remove |
|
"Later" still meaning before next release. |
Addresses #96. Turns out it was being used for hex encoding/decoding, so replaced that with the `hex` crate. i chose to import the `decode` method as: ``` use hex::decode as hex_decode ``` so that it is clear to the reader what is being decoded when it is called. "decode" is such a generic sounding function name that it would get confusing otherwise.
|
Yea, that seems fine to me, no reason to rush it, especially if its a git commit dep for now. |
|
cool - assuming nothing more is required for this PR. Let me know if any more changes are requested. |
Releave v0.11.0
* fixes * update rust version * update rust * cleanup
Addresses #96.
Turns out it was being used for hex encoding/decoding, so replaced that with the
hexcrate.i chose to import the
decodemethod as:so that it is clear to the reader what is being decoded when it is called. "decode" is such a generic sounding function name that it would get confusing otherwise.