Remove duplicate must_use#1063
Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom Jun 24, 2022
Merged
Conversation
Clippy emits: warning: this function has an empty `#[must_use]` attribute, but returns a type already marked as `#[must_use]` This is because the return type of the function `legacy_encode_signing_data_to` is `EncodeSigningDataResult` which is already marked as `must_use`. There is no need to have `must_use` on the function also. I'm guessing this got through to master because we only just added clippy to CI.
dpc
approved these changes
Jun 24, 2022
Member
|
Neat -- I also added |
apoelstra
approved these changes
Jun 24, 2022
Kixunil
approved these changes
Jun 24, 2022
Merged
ChallengeDev210
pushed a commit
to ChallengeDev210/rust-bitcoin
that referenced
this pull request
Aug 1, 2022
bea5569 Remove duplicate must_use (Tobin C. Harding) Pull request description: Clippy emits: warning: this function has an empty `#[must_use]` attribute, but returns a type already marked as `#[must_use]` This is because the return type of the function `legacy_encode_signing_data_to` is `EncodeSigningDataResult` which is already marked as `must_use`. There is no need to have `must_use` on the function also. ## Hey apoelstra, this PR is needed before any other PR can get a green CI run. The PR that introduced this warning must have had a green CI run before the 'add clippy to CI' PR merged allowing it to merge without re-running CI. ACKs for top commit: apoelstra: ACK bea5569 Kixunil: ACK bea5569 Tree-SHA512: 27b606685bc2d5317a5e332431511af9b1017bf58462c283b322e5b6faf645fd8e006455af3d6888ab2c3c680b11e4b89f538f26440f4f1422e0daabc61825ac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clippy emits:
warning: this function has an empty
#[must_use]attribute, but returns a type already marked as#[must_use]This is because the return type of the function
legacy_encode_signing_data_toisEncodeSigningDataResultwhich isalready marked as
must_use. There is no need to havemust_useon the function also.Hey apoelstra, this PR is needed before any other PR can get a green CI run. The PR that introduced this warning must have had a green CI run before the 'add clippy to CI' PR merged allowing it to merge without re-running CI.