We might want to add the unicode unpin, but I'm not sure what effect that will have. It's mostly pinned because that crate is known that have a different MSRV policy than we have and it has broken some of our crates in the past. So we can't rely on semver with them.

But like I mentioned before, since it's an unexposed dep, the pin shouldn't have any effect on dependent crates.

rebased and pushed

@tcharding I made some fixes and did the unicode-normalization fix. Could you review the commits (it wouldn't compile in my previous branch and you acked 😅 ) and could you also double check that it works in v1.41? I don't have rustup available on this machine, so I did some testing using Docker. I think it passes all tests in v1.41 with the rand feature tested.

Normally, using rustup, I used to use this script:

#!/bin/sh

set -e

MSRV="1.41.0"

CMD="rustup run ${MSRV}"

rm -f Cargo.lock
$CMD cargo generate-lockfile

$CMD cargo build --no-default-features
$CMD cargo test  --no-default-features
$CMD cargo build --no-default-features --features all-languages
$CMD cargo test  --no-default-features --features all-languages
$CMD cargo build --features rand,all-languages
$CMD cargo test  --features rand,all-languages

Let's merge and release the newly merged method in 1.x before merging this.

#44

That script runs, I made one change MSRV="1.41.1", which you had correct everywhere else.

Ok final rebase here after rebasing on v1.2.0 :)

As for 1.41.0/1 I wrote just 1.41 in most places. I did my tests with 1.41.0 and it seems to work.

As you prefer, in rust-bitcoin we always say 1.41.1 explicitly and I don't install the 1.41.0 toolchain myself.

There don't seem to be a significant difference, but I'll change it to 1.41.1 for consistency.

@tcharding test run and ack and should be good to go. I'm not happy with Travis disappearing and all my repos being left without CI :/

Rebased this MR on #45 to add CI, let's see. #45 passes