Fix order of 'got' and 'want' fields when populating InvalidLength error#88
Merged
apoelstra merged 1 commit intorust-bitcoin:0.1.xfrom May 13, 2024
Merged
Conversation
Error `HexToArrayError::InvalidLength` has two numeric fields 'got' and 'want' (in this order), however the two fields were populated in the opposite order. This patch fixes it.
tcharding
approved these changes
May 12, 2024
Member
|
The two failing CI jobs are ok and unrelated to this PR, its because the target branch is old. @apoelstra will also verify my claims when he runs his local CI before merging. Thanks for the PR @jirijakes. FTR this PR has a few more lines in the diff than I would have done myself but it does the job 100% and is only going to exist on the |
apoelstra
approved these changes
May 13, 2024
Member
|
Looks good! Note that we need a separate PR to bump the version number if we want to release this. |
Member
|
Done in #89 |
apoelstra
added a commit
that referenced
this pull request
May 14, 2024
0db5d68 Bump version to 0.2.1 (Tobin C. Harding) a009e25 fuzz: Remove explicit crate version (Tobin C. Harding) Pull request description: Two patches in preparation for doing a point release to release the bug fix in #88. - Patch 1: Remove the version number from `fuzz` manifest. - Patch 2: Add changelog and bump version. ACKs for top commit: apoelstra: ACK 0db5d68 Tree-SHA512: 68e70f54bac091ad2fc463ec0a32978269a9a9cace193d9283443f8a078d537286cc211f1504e2cefe6e7e3903943f29a062de5d9f5047d7a5e249d80c488db4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error
HexToArrayError::InvalidLengthhas two numeric fields 'got' and 'want' (in this order), however the two fields were populated in the opposite order. This patch fixes it and thus fixes #87.To crosscheck the order of fields:
hex-conservative/src/parse.rs
Lines 115 to 122 in bd9c2c7