Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1576 +/- ##
=======================================
Coverage 85.92% 85.92%
=======================================
Files 57 57
Lines 10670 10670
=======================================
Hits 9168 9168
Misses 1502 1502 ☔ View full report in Codecov by Sentry. |
cljoly
added a commit
to cljoly/rusqlite_migration
that referenced
this pull request
Jan 22, 2025
Starting with version [0.33](https://github.com/rusqlite/rusqlite/releases/tag/v0.33.0), rusqlite has a policy for the minimum supported rust version (see rusqlite/rusqlite#1576). Now, for now it means that the MSRV is effectively the latest Rust version, but that should change as new releases of Rust become stable (i.e. if 1.85 gets out before rusqlite gets a new version, we will again have a MSRV that’s not the latest stable Rust). Thus, it’s worth keeping the CI code to test two different versions.
cljoly
added a commit
to cljoly/rusqlite_migration
that referenced
this pull request
Jan 22, 2025
Starting with version [0.33](https://github.com/rusqlite/rusqlite/releases/tag/v0.33.0), rusqlite has a policy for the minimum supported rust version (see rusqlite/rusqlite#1576). Align our MSRV and rusqlite’s, if rusqlite doesn’t support a particular version (i.e. doesn’t compile), then rusqlite_migration can’t be used either. We could try to figure out what version of Rust still compiles with rusqlite, beyond their official MSRV, but that’s easy to get wrong and an additional support burden on us. Now, for now it means that the MSRV is effectively the latest Rust version, but that should change as new releases of Rust become stable (i.e. if 1.85 gets out before rusqlite gets a new version, we will again have a MSRV that’s not the latest stable Rust). Thus, it’s worth keeping the CI code to test two different versions.
cljoly
added a commit
to cljoly/rusqlite_migration
that referenced
this pull request
Jan 22, 2025
Starting with version [0.33](https://github.com/rusqlite/rusqlite/releases/tag/v0.33.0), rusqlite has a policy for the minimum supported rust version (see rusqlite/rusqlite#1576). Align our MSRV and rusqlite’s, if rusqlite doesn’t support a particular version (i.e. doesn’t compile), then rusqlite_migration can’t be used either. We could try to figure out what version of Rust still compiles with rusqlite, beyond their official MSRV, but that’s easy to get wrong and an additional support burden on us. Now, for now it means that the MSRV is effectively the latest Rust version, but that should change as new releases of Rust become stable (i.e. if 1.85 gets out before rusqlite gets a new version, we will again have a MSRV that’s not the latest stable Rust). Thus, it’s worth keeping the CI code to test two different versions.
cljoly
added a commit
to cljoly/rusqlite_migration
that referenced
this pull request
Feb 1, 2025
Starting with version [0.33](https://github.com/rusqlite/rusqlite/releases/tag/v0.33.0), rusqlite has a policy for the minimum supported rust version (see rusqlite/rusqlite#1576). Align our MSRV and rusqlite’s, if rusqlite doesn’t support a particular version (i.e. doesn’t compile), then rusqlite_migration can’t be used either. We could try to figure out what version of Rust still compiles with rusqlite, beyond their official MSRV, but that’s easy to get wrong and an additional support burden on us. Now, for now it means that the MSRV is effectively the latest Rust version, but that should change as new releases of Rust become stable (i.e. if 1.85 gets out before rusqlite gets a new version, we will again have a MSRV that’s not the latest stable Rust). Thus, it’s worth keeping the CI code to test two different versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.