Skip to content

Conversation

@yuhr
Copy link
Member

@yuhr yuhr commented Jan 11, 2025

No description provided.

@coveralls
Copy link
Collaborator

coveralls commented Jan 11, 2025

Pull Request Test Coverage Report for Build 12725604011

Details

  • 64 of 72 (88.89%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 93.539%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Intersect.ts 46 54 85.19%
Totals Coverage Status
Change from base Build 12724383071: -0.4%
Covered Lines: 1556
Relevant Lines: 1651

💛 - Coveralls

@yuhr yuhr force-pushed the fix/parser-union-intersect branch from c576377 to 67e8107 Compare January 11, 2025 15:55
@yuhr yuhr merged commit f9ff327 into master Jan 11, 2025
1 check passed
@yuhr yuhr deleted the fix/parser-union-intersect branch January 11, 2025 15:56
yuhr added a commit that referenced this pull request Jan 16, 2025
#442 sometimes produced unsound type inference, such as in case where
properties with the same name might be parsed into different values.

```typescript
const P = Object({ n: String.withParser(() => 1 as const) })
const N = Object({ n: String.withParser(parseInt) })
const PN = P.and(N)
assertEquals(PN.parse({ n: "42" }).n, 1)
// `n` is infered as `1`, but `undefined` actually.
```

I can't imagine any viable solution to this, so reverting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants