add compiler patch (cf ocaml/ocaml#406)#5
Merged
dwightguth merged 1 commit intomasterfrom Jan 20, 2016
Merged
Conversation
Contributor
There was a problem hiding this comment.
Why is this faster, out of curiosity? Why is the last case not "_ -> false"?
Contributor
Author
There was a problem hiding this comment.
this is faster because polymorphic comparison is super slow. The idea behind the last case is that by writing it this way, it's not any slower once compiled, but if a new case is added to the constructor_tag type, a warning will be outputted that this function is no longer correct. I implemented it this way at the request of the OCAML developers after I submitted the original PR to them.
Contributor
|
Ok, looks good then. |
dwightguth
pushed a commit
that referenced
this pull request
Jan 20, 2016
add compiler patch (cf ocaml/ocaml#406)
rv-jenkins
added a commit
that referenced
this pull request
Mar 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@chathhorn please review
Should shave about 200 ms off the time to kcc.