Conversation
…gration setup - Added integration test suite with setup and teardown scripts for Kubernetes cluster. - Introduced new Makefile targets for integration testing: `setup-integration`, `test-integration`, and `teardown-integration`. - Created `values.yaml` for configuration of GPU resources and device plugins. - Updated device class name in deployment manifests to align with new naming conventions. - Enhanced health check configurations for the DRA plugin. - Removed deprecated deployment example file.
…orkflow to add dra-plugin-gpu component
… directory and initialize checkpoints. Added checkpoint.json for managing prepared claims.
- Introduced a new 'integration' job in the CI workflow to run integration tests. - Set up Go and Docker Buildx for the integration environment. - Installed 'kind' for Kubernetes cluster management. - Updated the release-docker job dependencies to include the new integration tests.
…app runner - Simplified the main application logic by creating a new app runner in dra-plugin-gpu. - Moved configuration and initialization logic into a dedicated DraPluginGpuApp struct. - Enhanced environment variable handling for NODE_NAME in CDI specifications. - Improved directory validation and creation processes. - Updated tests to ensure NODE_NAME is correctly set in the CDI spec files.
…andard log package - Removed usage of klog in favor of the standard log package for logging. - Updated Shutdown methods to eliminate logger parameters. - Adjusted logging statements throughout the codebase for consistency and clarity. - Cleaned up go.mod and go.sum by removing unused dependencies.
iris-shain-runai
approved these changes
Dec 15, 2025
…ty. Updated comments to indicate that error scenarios are covered by integration tests and noted the need for dependency injection in certain tests.
… dependency on kubeletplugin.Helper and note that this is covered by integration tests.
eliranw
added a commit
that referenced
this pull request
Dec 16, 2025
1. Added DRA gpu plugin component based on https://github.com/NVIDIA/k8s-dra-driver-gpu/ 2. Added helm chart new resources as well as enable/disable to all components 3. Added unit testing + integration testing - currently only for dra-driver-gpu + setup/teardown scripts 4. updated cicd/docker/makefiles for the new component 5. updated nvidia-smi binary to try to utilize local env for topology before fallback to http
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.