Skip to content

text: Set TextFormat.display to block by default#23165

Merged
kjarosh merged 3 commits intoruffle-rs:masterfrom
kjarosh:tf-display-null
Mar 2, 2026
Merged

text: Set TextFormat.display to block by default#23165
kjarosh merged 3 commits intoruffle-rs:masterfrom
kjarosh:tf-display-null

Conversation

@kjarosh
Copy link
Copy Markdown
Member

@kjarosh kjarosh commented Mar 2, 2026

Fixes a regression introduced by #22636: #23158.

Every time when TextFormat is instantiated in Ruffle, we need to specify display = block, which suggests that display = block is the default in Flash.

This fixes a case where in one place it wasn't set, but should have been.

@kjarosh kjarosh added text Issues relating to text rendering/input A-core Area: Core player, where no other category fits T-fix Type: Bug fix (in something that's supposed to work already) labels Mar 2, 2026
@kjarosh kjarosh added the waiting-on-review Waiting on review from a Ruffle team member label Mar 2, 2026
@kjarosh kjarosh removed the waiting-on-review Waiting on review from a Ruffle team member label Mar 2, 2026
kjarosh added 3 commits March 2, 2026 18:43
Every time when TextFormat is instantiated in Ruffle, we need to specify
display = block, which suggests that display = block is the default in
Flash.

This fixes a case where in one place it wasn't set, but should have
been.
@kjarosh kjarosh enabled auto-merge (rebase) March 2, 2026 17:43
@kjarosh kjarosh merged commit 7cbe587 into ruffle-rs:master Mar 2, 2026
26 checks passed
@kjarosh kjarosh deleted the tf-display-null branch March 2, 2026 17:57
Hancock33 added a commit to Hancock33/batocera.piboy that referenced this pull request Mar 8, 2026
--------------------------------------------------------------------------------------------------------
batocera-emulationstation.mk ffdd100af396a482143166ef63b997c8b3d7663a # Version: Commits on Mar 03, 2026
--------------------------------------------------------------------------------------------------------
Merge pull request #2089 from lbrpdx/trans_pl

hotkeys GUI: add OSD keyboard and recording start/stop,

------------------------------------------------------------------------------------------------
batocera-es-piboy.mk ffdd100af396a482143166ef63b997c8b3d7663a # Version: Commits on Mar 03, 2026
------------------------------------------------------------------------------------------------
Merge pull request #2089 from lbrpdx/trans_pl

hotkeys GUI: add OSD keyboard and recording start/stop,

-------------------------------------------------------------------------------------
azahar.mk 93e831decbe545fbd40a6b310ec56b13a69f00f1 # Version: Commits on Mar 03, 2026
-------------------------------------------------------------------------------------
android: Fixed invalid default config content, resulting in a crash,

------------------------------------------------------------------------------------------
dolphin-emu.mk 43def54de2c67450333046d3bee8275d5acaa239 # Version: Commits on Mar 03, 2026
------------------------------------------------------------------------------------------
Merge pull request #14435 from Simonx22/fix/metal-early-stop-shutdown

Metal: Always run endEncoding on command encoders,

------------------------------------------------------------------------------------------
duckstation.mk 26fda0b98546ad724c08cd376cb5e1f51029b810 # Version: Commits on Mar 03, 2026
------------------------------------------------------------------------------------------
CPU/Recompiler: Don't clobber downcount in GTE blocks

Bad translation from x86, where it used a memory operand and didn't need

the second argument register.

Net result would have been events that should have triggered being

delayed until the next non-GTE block.,

-----------------------------------------------------------------------------------
eden.mk 9d2341eaeafb275d3d3e4692812fe121ae24e2e3 # Version: Commits on Mar 03, 2026
-----------------------------------------------------------------------------------
[vk] Disable float16 math on non-MESA AMD drivers as 2026+ versions are broken (#3661)

-------------------------------------------------------------------------------------
ppsspp.mk 69fc91b36fc7ed9224c47486f687f8be62e13c0d # Version: Commits on Mar 03, 2026
-------------------------------------------------------------------------------------
Merge pull request #21331 from Felipefpl/master

Updated brazilian portuguese translation,

------------------------------------------------------------------------------------
rpcs3.mk 595e42c4f3bfa11b8585ea029e1aa9d2c9c68fd1 # Version: Commits on Mar 01, 2026
------------------------------------------------------------------------------------
rpcs3_version: Bump to 0.0.40,

-------------------------------------------------------------------------------------------
xenia-canary.mk dbfe2167549d079febb1606e4ff72bcb9513e0e8 # Version: Commits on Mar 03, 2026
-------------------------------------------------------------------------------------------
[Vulkan] Implement extended range for f32 to f16 conversion in memexport,

-------------------------------------------------------------------------------------------
xenia-native.mk dbfe2167549d079febb1606e4ff72bcb9513e0e8 # Version: Commits on Mar 03, 2026
-------------------------------------------------------------------------------------------
[Vulkan] Implement extended range for f32 to f16 conversion in memexport,

---------------------------------------------------------------
ruffle.mk nightly-2026-03-03 # Version: Commits on Mar 03, 2026
---------------------------------------------------------------
## What's Changed

* build(deps-dev): bump the npm-minor group in /web with 6 updates by @dependabot[bot] in ruffle-rs/ruffle#23166

* text: Set TextFormat.display to block by default by @kjarosh in ruffle-rs/ruffle#23165

**Full Changelog**: ruffle-rs/ruffle@nightly-2026-03-02...nightly-2026-03-03,

---------------------------------------------------------------------------------------
thextech.mk 409b79233cd36709bedcb988475567da23224532 # Version: Commits on Mar 02, 2026
---------------------------------------------------------------------------------------
game_save.cpp: DO store IDs for visible items

(These carry no information, but are required by earlier versions of TheXTech),

-----------------------------------------------------------------------------------------
sdl3_mixer.mk 5aa3eb61843d2320b69cc99aac13f4a8eacfe3d0 # Version: Commits on Mar 03, 2026
-----------------------------------------------------------------------------------------
Android.mk: Split libogg support between sublibraries, add libvorbis support.

Previously the Android builds only supported libtremor, but that library is

really intended for low-powered embedded devices without hardware floating

point, which doesn't describe most (any?) Android devices in modern times.

Reasonable hardware should be using libvorbis instead.,

------------------------------------------------------------------------------------
box64.mk 7e5310b26001bce62e2a23fd412d8f2b3694c082 # Version: Commits on Mar 03, 2026
------------------------------------------------------------------------------------
cpuid: Enable Invariant TSC bit for Intel CPU type (#3579)

* cpuid: Enable Invariant TSC bit for Intel CPU type

The Invariant TSC bit (CPUID leaf 0x80000007, EDX bit 8) was already

enabled for AMD CPU type but was commented out for Intel CPU type.

ARM64 provides an invariant system counter via CNTPCT_EL0, so

advertising Invariant TSC capability is correct on ARM64 hardware

regardless of the emulated CPU vendor.

Some applications (notably World of Warcraft and VanillaFixes) check

this bit and refuse to run or crash when it is not set.

Fixes #2485

* Gate Invariant TSC behind BOX64_RDTSC_INV env var

Software often reports the timer clock as the CPU clock, which

is incorrect under Box64. Make the Invariant TSC bit in CPUID

leaf 0x80000007 opt-in for the Intel CPU type path via

BOX64_RDTSC_INV=1 (disabled by default).

The AMD CPU type path already reports this bit unconditionally.

* cpuid: fix BOX64_RDTSC_INV availability in WowBox64.dll and sanitize comments

- Set wine flag to 1 so BOX64_RDTSC_INV is parseable and initialised

  correctly when compiled as WowBox64.dll (_WIN32 context)

- Remove verbose comment annotation; env var name is evident from code

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Joe <joe@Joes-MacBook-Pro.local>

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>,

-----------------------------------------------------------------------------------------
catacombgl.mk 197488b5d945920c89ff99ca2bdc2722bab34b63 # Version: Commits on Mar 02, 2026
-----------------------------------------------------------------------------------------
Introduce class test for PlayerInventory,

---------------------------------------------------------------------------------------
etlegacy.mk 5296dd2ff65b480525593acf4d137cebb8111430 # Version: Commits on Mar 03, 2026
---------------------------------------------------------------------------------------
cgame: set visibility defaults,

-------------------------------------------------------------------------------------------
jazz2-native.mk 987f60799eeecc2f90384246cda8dd2f00b892e5 # Version: Commits on Mar 02, 2026
-------------------------------------------------------------------------------------------
Merge branch 'master' of https://github.com/deathkiller/jazz2-native,

----------------------------------------------------------------------------------------
openmohaa.mk 87dd1f650e486363d5da31c1552f0e2acf333880 # Version: Commits on Mar 02, 2026
----------------------------------------------------------------------------------------
fix(fgame): fix vehiclesoundentity_postspawn event name (#899),

----------------------------------------------------------------------------------
stk.mk f68334ead5449bc7777cf758dea6cdfa4ec27598 # Version: Commits on Mar 03, 2026
----------------------------------------------------------------------------------
Sanitize illegal characters from download filename. (#5643)

Prevent /installaddon from failing (especially on windows) when the basename contains characters that are illegal in popular filesystems.,

-------------------------------------------------------------------------------------------------
shadps4-qtlauncher.mk 9bccf1efc73f336cb7880d91377d467ff2219831 # Version: Commits on Mar 03, 2026
-------------------------------------------------------------------------------------------------
New Crowdin updates (#259)

* New translations en_us.ts (Spanish)

* New translations en_us.ts (Portuguese, Brazilian),

-------------------------------------------------------
syncthing.mk v2.0.15 # Version: Commits on Mar 03, 2026
-------------------------------------------------------
## Major changes in 2.0

- Database backend switched from LevelDB to SQLite. There is a migration on

  first launch which can be lengthy for larger setups. The new database is

  easier to understand and maintain and, hopefully, less buggy.

- The logging format has changed to use structured log entries (a message

  plus several key-value pairs). Additionally, we can now control the log

  level per package, and a new log level WARNING has been inserted between

  INFO and ERROR (which was previously known as WARNING...). The INFO level

  has become more verbose, indicating the sync actions taken by Syncthing. A

  new command line flag `--log-level` sets the default log level for all

  packages, and the `STTRACE` environment variable and GUI has been updated

  to set log levels per package. The `--verbose` and `--logflags` command

  line options have been removed and will be ignored if given.

- Deleted items are no longer kept forever in the database, instead they are

  forgotten after fifteen months. If your use case require deletes to take

  effect after more than a fifteen month delay, set the

  `--db-delete-retention-interval` command line option or corresponding

  environment variable to zero, or a longer time interval of your choosing.

- Modernised command line options parsing. Old single-dash long options are

  no longer supported, e.g. `-home` must be given as `--home`. Some options

  have been renamed, others have become subcommands. All serve options are

  now also accepted as environment variables. See  `syncthing --help` and

  `syncthing serve --help` for details.

- Rolling hash detection of shifted data is no longer supported as this

  effectively never helped. Instead, scanning and syncing is faster and more

  efficient without it.

- A \default folder\ is no longer created on first startup.

- Multiple connections are now used by default between v2 devices. The new

  default value is to use three connections: one for index metadata and two

  for data exchange.

- The following platforms unfortunately no longer get prebuilt binaries for

  download at syncthing.net and on GitHub, due to complexities related to

  cross compilation with SQLite:

  - dragonfly/amd64

  - solaris/amd64

  - linux/ppc64

  - netbsd/*

  - openbsd/386 and openbsd/arm

  - windows/arm

- The handling of conflict resolution involving deleted files has changed. A

  delete can now be the winning outcome of conflict resolution, resulting in

  the deleted file being moved to a conflict copy.

This release is also available as:

* APT repository: https://apt.syncthing.net/

* Docker image: `docker.io/syncthing/syncthing:2.0.15` or `ghcr.io/syncthing/syncthing:2.0.15`

  (`{docker,ghcr}.io/syncthing/syncthing:2` to follow just the major version)

## What's Changed

### Fixes

* fix(gui): show restarting modal during upgrade restart (fixes #1248) by @steadytao in syncthing/syncthing#10566

* fix(gui): remove width limit for language select items by @EastSun5566 in syncthing/syncthing#10531

### Other

* chore(gui): add id and name to Stay logged in checkbox for password managers by @epifeny in syncthing/syncthing#10558

* chore(db): add ability to wait for programmatically started database maintenance, query last maintenance time by @pixelspark in syncthing/syncthing#10565

* chore(etc): add comprehensive sandboxing by @Valloric in syncthing/syncthing#10421

* chore: build with Go 1.26; use Go 1.25 features by @calmh in syncthing/syncthing#10570

## New Contributors

* @epifeny made their first contribution in syncthing/syncthing#10558

* @steadytao made their first contribution in syncthing/syncthing#10566

* @EastSun5566 made their first contribution in syncthing/syncthing#10531

* @Valloric made their first contribution in syncthing/syncthing#10421

**Full Changelog**: syncthing/syncthing@v2.0.14...v2.0.15,

----------------------------------------------------------------------------------------
retroarch.mk c335fa96533a0e007bbee6ee68917dc584d17cba # Version: Commits on Mar 03, 2026
----------------------------------------------------------------------------------------
apple: add applewin and azahar cores to App Store builds

azahar core still to come,

--------------------------------------------------------------------------------------------
vpinball-next.mk 0131accc543473aaa0685d3190b2ff946cf72e1d # Version: Commits on Mar 03, 2026
--------------------------------------------------------------------------------------------
standalone: add support for new IDecalEvents (#3195),

----------------------------------------------------------------------------------------
doomretro.mk 9796203f7d859c74129c4b8337a6f2359511b607 # Version: Commits on Mar 03, 2026
----------------------------------------------------------------------------------------
Minor tweaks,

----------------------------------------------------------------------------------
trx.mk e13213fc1e52da3d8a218681822c3216e55869e3 # Version: Commits on Mar 03, 2026
----------------------------------------------------------------------------------
test-replay: fix desync config state,

--------------------------------------------------------------------------------------------------
libretro-clownmdemu.mk ce2c83361bacf1aec301befe5fa4023db2eda839 # Version: Commits on Mar 03, 2026
--------------------------------------------------------------------------------------------------
Bump version to v1.6.7.,

---------------------------------------------------------------------------------------------
libretro-fbneo.mk 7706b59fecf5a8ef81190d8d7e0abe3b08ce6d22 # Version: Commits on Mar 03, 2026
---------------------------------------------------------------------------------------------
(libretro) update files,

--------------------------------------------------------------------------------------------------
libretro-melonds-ds.mk bac0256dc6a8736c5a228f57c562257e45fd49f3 # Version: Commits on Mar 03, 2026
--------------------------------------------------------------------------------------------------
Disable LTO on Android,

--------------------------------------------------------------------------------------------------------
libretro-mupen64plus-next.mk 899eaf6d629b264fedc9afd45a5e01895045a90b # Version: Commits on Feb 06, 2026
--------------------------------------------------------------------------------------------------------
Disable ext_fetch (GL_EXT_shader_framebuffer_fetch) on freedreno desktop OpenGL

as it causes rendering issues with N64 depth compare.,

----------------------------------------------------------------------------------------------
libretro-ppsspp.mk 69fc91b36fc7ed9224c47486f687f8be62e13c0d # Version: Commits on Mar 03, 2026
----------------------------------------------------------------------------------------------
Merge pull request #21331 from Felipefpl/master

Updated brazilian portuguese translation,

----------------------------------------------------------------------------------------------
libretro-stella.mk b89c2fecb2a00449c484f47ff8437bce2db1b5b9 # Version: Commits on Mar 02, 2026
----------------------------------------------------------------------------------------------
Fix Windows build from recent ZLIB update.,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-core Area: Core player, where no other category fits T-fix Type: Bug fix (in something that's supposed to work already) text Issues relating to text rendering/input

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants