Skip to content

avm1: Execute loader events in the context of base movie#22887

Merged
kjarosh merged 2 commits intoruffle-rs:masterfrom
kjarosh:avm1-loader-events-base-movie
Jan 31, 2026
Merged

avm1: Execute loader events in the context of base movie#22887
kjarosh merged 2 commits intoruffle-rs:masterfrom
kjarosh:avm1-loader-events-base-movie

Conversation

@kjarosh
Copy link
Copy Markdown
Member

@kjarosh kjarosh commented Jan 30, 2026

Loader events should be executed in the context of the base movie, not the target movie. Otherwise, we'll infer e.g. wrong SWF version.

@kjarosh kjarosh added A-avm1 Area: AVM1 (ActionScript 1 & 2) T-compat Type: Compatibility with Flash Player labels Jan 30, 2026
@kjarosh kjarosh force-pushed the avm1-loader-events-base-movie branch from cfbe1c0 to c909245 Compare January 30, 2026 23:59
@kjarosh kjarosh force-pushed the avm1-loader-events-base-movie branch 3 times, most recently from 9bbb651 to 6ba76f1 Compare January 31, 2026 11:22
Loader events should be executed in the context of the base movie, not
the target movie.  Otherwise, we'll infer e.g. wrong SWF version.
@kjarosh kjarosh force-pushed the avm1-loader-events-base-movie branch from 6ba76f1 to b79791d Compare January 31, 2026 15:26
@kjarosh kjarosh force-pushed the avm1-loader-events-base-movie branch from b79791d to 50fe784 Compare January 31, 2026 17:42
@kjarosh kjarosh enabled auto-merge (rebase) January 31, 2026 17:51
@kjarosh kjarosh merged commit 81379bb into ruffle-rs:master Jan 31, 2026
26 checks passed
@kjarosh kjarosh deleted the avm1-loader-events-base-movie branch January 31, 2026 17:55
Hancock33 added a commit to Hancock33/batocera.piboy that referenced this pull request Feb 1, 2026
-----------------------------------------------------------------------------------
cemu.mk ba82dc57d64fe8fc1b268e24fa583b350404b9a6 # Version: Commits on Feb 01, 2026
-----------------------------------------------------------------------------------
OpenGL+Vulkan: Use unified uniform block layout for output shaders (#1785),

------------------------------------------------------------------------------------------
duckstation.mk 7e4efbfa9c25345834a351f991a456154444a448 # Version: Commits on Feb 01, 2026
------------------------------------------------------------------------------------------
CI: Generate Windows installers,

-----------------------------------------------------------------------------------
eden.mk 6637810fe6c6610f73f0b1b12e56e9b48268d0ee # Version: Commits on Feb 01, 2026
-----------------------------------------------------------------------------------
[android] gpu logs functions (#3389)

---------------------------------------------------
pcsx2.mk v2.7.89 # Version: Commits on Feb 01, 2026
---------------------------------------------------
- [GS/DX11: Misc fixes](PCSX2/pcsx2#13922)

,

-----------------------------------------------------
ryujinx.mk 1.3.252 # Version: Commits on Feb 01, 2026
-----------------------------------------------------
Canary-1.3.252

-----------------------------------------------------------------------------------
ymir.mk 2e4f0a6f9472e50c949608b31ae3065ec6eec520 # Version: Commits on Feb 01, 2026
-----------------------------------------------------------------------------------
fix(savestates): Fix off-by-one error in save state lists in menus,

---------------------------------------------------------------
ruffle.mk nightly-2026-02-01 # Version: Commits on Feb 01, 2026
---------------------------------------------------------------
## What's Changed

* core: Use get_loader instead of get_loader_mut where possible by @kjarosh in ruffle-rs/ruffle#22888

* text: Tests and fixes related to the default text format by @kjarosh in ruffle-rs/ruffle#22636

* avm1: Execute loader events in the context of base movie by @kjarosh in ruffle-rs/ruffle#22887

* tests: Fix initial movie clip URL by @kjarosh in ruffle-rs/ruffle#22893

* core: Remove double references to MovieClips by @kjarosh in ruffle-rs/ruffle#22895

**Full Changelog**: ruffle-rs/ruffle@nightly-2026-01-31...nightly-2026-02-01,

------------------------------------------------------------------------------------
box64.mk 3bbb84502e8061d6fb5543e505c8301198d87494 # Version: Commits on Feb 01, 2026
------------------------------------------------------------------------------------
[INTEGRATION] Added /opt/box64/lib[32/64] as system folder for easier system integration,

----------------------------------------------------------------------------------------
openmohaa.mk 02de33a5c88efcbdeb70f352c7a417b8b6760ee3 # Version: Commits on Feb 01, 2026
----------------------------------------------------------------------------------------
docs(changelog): update changelog,

----------------------------------------------------------------------------------------
supertux2.mk da4b9aa263f5d039916c73323abbc6f864690815 # Version: Commits on Feb 01, 2026
----------------------------------------------------------------------------------------
unglint enemy in maze in the sky,

-------------------------------------------------------------------------------------------------
shadps4-qtlauncher.mk 4ba1bfd3e24aa86135e27bfb53b4fc1298cc85f7 # Version: Commits on Feb 01, 2026
-------------------------------------------------------------------------------------------------
New Crowdin updates (#239)

* New translations en_us.ts (Japanese)

* New translations en_us.ts (Ukrainian)

* New translations en_us.ts (Ukrainian)

* New translations en_us.ts (Turkish)

* New translations en_us.ts (Turkish)

* New translations en_us.ts (Portuguese, Brazilian)

* New translations en_us.ts (Urdu (Pakistan))

* New translations en_us.ts (Urdu (Pakistan)),

----------------------------------------------------------------------------------------
retroarch.mk 9804687c7bc832a65cdff4f5d2bf7242e131337b # Version: Commits on Feb 01, 2026
----------------------------------------------------------------------------------------
metal: try not to crash quite as much,

----------------------------------------------------------------------------------------
doomretro.mk d93afd5a8ead497895c67acf095a010bdefdd535 # Version: Commits on Feb 01, 2026
----------------------------------------------------------------------------------------
Recognize animated flats with `SW[A]MP` in name as liquid,

----------------------------------------------------------------------------------
trx.mk 9417689fc6de5ab72a8cc83f80dffb2102f0cce8 # Version: Commits on Jan 31, 2026
----------------------------------------------------------------------------------
objects: use new io for priv data,

--------------------------------------------------------------------------------------------------
libretro-clownmdemu.mk 669491083ed40ca84561ae88a4ba43aac593299d # Version: Commits on Jan 31, 2026
--------------------------------------------------------------------------------------------------
Update common.

Now with CHD support!,

--------------------------------------------------------------------------------------------
libretro-pc98.mk 15676585b9a370e874ea9309252bd8236df3f642 # Version: Commits on Feb 01, 2026
--------------------------------------------------------------------------------------------
SDL3,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-avm1 Area: AVM1 (ActionScript 1 & 2) T-compat Type: Compatibility with Flash Player

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants