Skip to content

Conversation

@InvoxiPlayGames
Copy link
Contributor

Event handlers (onLoad, parseXML, etc) in XML and XMLSocket should always reference the base clip that defined the function to ensure the corresponding function block runs in the right context - this PR updates them to use the Special execution reason. This didn't affect SWFv6 and above due to these event handler calls being treated as closures and always referencing the base clip.

This fixes the Fanstuff / Sketchbook / Random functionality on https://homestarrunner.com/main6.html

image

@InvoxiPlayGames InvoxiPlayGames force-pushed the avm1_xml_event_handler branch from 6417e1c to 6c9d6ee Compare April 23, 2025 18:14
@Lord-McSweeney Lord-McSweeney added A-avm1 Area: AVM1 (ActionScript 1 & 2) T-fix Type: Bug fix (in something that's supposed to work already) labels Apr 23, 2025
@torokati44 torokati44 force-pushed the avm1_xml_event_handler branch from 6c9d6ee to 0a547c4 Compare April 23, 2025 18:47
@torokati44 torokati44 enabled auto-merge (rebase) April 23, 2025 18:48
@torokati44
Copy link
Member

Thank you!

@torokati44 torokati44 merged commit ff2dfec into ruffle-rs:master Apr 23, 2025
22 checks passed
Hancock33 added a commit to Hancock33/batocera.piboy that referenced this pull request Apr 27, 2025
--------------------------------------------------------------------------------------------------------
batocera-emulationstation.mk 08d03834ce26b688b4bd6d04a2e084be70421aad # Version: Commits on Apr 24, 2025
--------------------------------------------------------------------------------------------------------
Merge pull request #1908 from fabricecaruso/win

[GLES20Renderer] Fix shaders performance issues & optimize with a cached texture when possible,

------------------------------------------------------------------------------------------------
batocera-es-piboy.mk 08d03834ce26b688b4bd6d04a2e084be70421aad # Version: Commits on Apr 24, 2025
------------------------------------------------------------------------------------------------
Merge pull request #1908 from fabricecaruso/win

[GLES20Renderer] Fix shaders performance issues & optimize with a cached texture when possible,

------------------------------------------------------------------------------------------
dolphin-emu.mk 8fa725d5e4feb3523f6c97d81a7896e94a47b5cd # Version: Commits on Apr 24, 2025
------------------------------------------------------------------------------------------
Merge pull request #13573 from tygyh/DolphinTool-Make-parameter-constant

DolphinTool: Make parameter constant,

------------------------------------------------------------------------------------------
duckstation.mk 674816b6eb3dc47ff0cecbd6935e29c672fb2326 # Version: Commits on Apr 24, 2025
------------------------------------------------------------------------------------------
GameDB: Recompiler ICache for Crypt Killer

Justifier handlers are timing sensitive.,

-------------------------------------------------------------------------------------
ikemen.mk 5496ee194bc07a84828a2f978a53dc3c1412b70c # Version: Commits on Apr 24, 2025
-------------------------------------------------------------------------------------
style: fix code style issues with gofmt,

-------------------------------------------------------------------------------------
ppsspp.mk a39eb4dc4ba05f5c7d292f7547a1502986b07e9f # Version: Commits on Apr 23, 2025
-------------------------------------------------------------------------------------
Merge pull request #20291 from oltolm/asan

ASAN,

---------------------------------------------------------------
ruffle.mk nightly-2025-04-24 # Version: Commits on Apr 24, 2025
---------------------------------------------------------------
## What's Changed

* avm1: fix incorrect XML event handler context in SWFv5 (close #20241) by @InvoxiPlayGames in ruffle-rs/ruffle#20249

* extension: Add exclusion for TikTok by @n0samu in ruffle-rs/ruffle#20250

## New Contributors

* @InvoxiPlayGames made their first contribution in ruffle-rs/ruffle#20249

**Full Changelog**: ruffle-rs/ruffle@nightly-2025-04-23...nightly-2025-04-24,

----------------------------------------------------
ryujinx.mk 1.3.35 # Version: Commits on Apr 24, 2025
----------------------------------------------------
# Canary builds:

These builds are experimental and may sometimes not work, use [regular builds](https://github.com/Ryubing/Stable-Releases/releases/latest) instead if that sounds like something you don't want to deal with.

| Platform | Artifact |

|--|--|

| Windows 64-bit | [Canary Windows Artifact](https://github.com/Ryubing/Canary-Releases/releases/download/1.3.35/ryujinx-canary-1.3.35-win_x64.zip) |

| Windows ARM 64-bit | [Canary Windows ARM Artifact](https://github.com/Ryubing/Canary-Releases/releases/download/1.3.35/ryujinx-canary-1.3.35-win_arm64.zip) |

| Linux 64-bit | [Canary Linux Artifact](https://github.com/Ryubing/Canary-Releases/releases/download/1.3.35/ryujinx-canary-1.3.35-linux_x64.tar.gz) |

| Linux ARM 64-bit | [Canary Linux ARM Artifact](https://github.com/Ryubing/Canary-Releases/releases/download/1.3.35/ryujinx-canary-1.3.35-linux_arm64.tar.gz) |

| macOS | [Canary macOS Artifact](https://github.com/Ryubing/Canary-Releases/releases/download/1.3.35/ryujinx-canary-1.3.35-macos_universal.app.tar.gz) |

**[Full Changelog](https://git.ryujinx.app/ryubing/ryujinx/-/compare/Canary-1.3.34...Canary-1.3.35)**,

-----------------------------------------------------------------------------------------
supermodel.mk 14df6d907a3226c55f0bf92fe98c85c18b1bb49a # Version: Commits on Apr 24, 2025
-----------------------------------------------------------------------------------------
ppcd now built with Supermodel and fixed warnings in PPCDisasm.cpp and check for Reuslt::OKAY,

-------------------------------------------------------------------------------------
vita3k.mk b9cf81a7765d3232f1fa4299903594cc2f475f1c # Version: Commits on Nov 10, 2024
-------------------------------------------------------------------------------------
gui: improve settings dialog,

------------------------------------------------------
appstream.mk v1.0.5 # Version: Commits on Apr 24, 2025
------------------------------------------------------
Release version 1.0.5,

------------------------------------------------------------------------------------
box64.mk 4585b74310598068c36f9b9b30a940d7e96a1e1d # Version: Commits on Apr 24, 2025
------------------------------------------------------------------------------------
[ARM64_DYNAREC] Some optimisation to some (V)(P)BLEND* opcodes,

---------------------------------------------------------------------------------------
corsixth.mk 1763a88a5955f52059b35f18ee60e63ac58dea40 # Version: Commits on Apr 24, 2025
---------------------------------------------------------------------------------------
[RDY] Money Bar non-CJK unicode fix (#2827)

* Money Bar non-CJK unicode fix

Co-authored-by: Toby <mrtobylane@gmail.com>

---------

Co-authored-by: Toby <mrtobylane@gmail.com>,

------------------------------------------------------------------------------------------
devilutionx.mk f1a9db8f59240ddeff84f63a628ca4d99b058b94 # Version: Commits on Apr 24, 2025
------------------------------------------------------------------------------------------
Extract the vision algorithm to a separate library

This allows us to test it without depending on all of DevilutionX.

Also fixes all clang-tidy warnings in the algorithm.,

-------------------------------------------------------------------------------------------
jazz2-native.mk 3e0cafa700389e3759f65c05c3835fd5c36f82b2 # Version: Commits on Apr 24, 2025
-------------------------------------------------------------------------------------------
Multiplayer, ranking,

--------------------------------------------------------------------------------------
omf2097.mk c9fc31f95984c692ab6d3da354984ab720a27392 # Version: Commits on Apr 23, 2025
--------------------------------------------------------------------------------------
Merge pull request #1219 from omf2097/adt/early-input

Send delayed events to peer early,

--------------------------------------------------------------
syncthing.mk v2.0.0-beta.11 # Version: Commits on Apr 24, 2025
--------------------------------------------------------------
## Major changes

- Database backend switched from LevelDB to SQLite. There is a migration on first launch which can be lengthy for larger setups. The new database is easier to understand and maintain and, hopefully, less buggy.

- Deleted items are no longer kept forever in the database, instead they are forgotten after six months. If your use case require deletes to take effect after more than a six month delay, set the `--db-delete-retention-interval` command line option or corresponding environment variable to zero, or a longer time interval of your choosing.

- Modernised command line options parsing. Old single-dash long options are no longer supported, e.g. `-home` must be given as `--home`. All serve options are now also accepted as environment variables.

- Rolling hash detection of shifted data is no longer supported as this effectively never helped. Instead, scanning and syncing is faster and more efficient without it.

- A \default folder\ is no longer created on first startup.

### Debian packages

```

deb [signed-by=/etc/apt/keyrings/syncthing-archive-keyring.gpg] https://apt.syncthing.net/ syncthing v2

```

### Docker image

```

ghcr.io/syncthing/syncthing:v2.0.0-beta.11

```

## What's Changed

* fix(osutil): give threads same I/O priority on Linux by @TheCreeper in syncthing/syncthing#10063

* chore(syncthing): remove support for TLS 1.2 sync connections by @calmh in syncthing/syncthing#10064

* chore(gui): update dependency copyrights, add script for periodic maintenance by @rasa in syncthing/syncthing#10067

* chore(syncthing): remove \default\ folder concept by @calmh in syncthing/syncthing#10068

* chore(api): log X-Forwarded-For by @bt90 in syncthing/syncthing#10035

* feat(config): add option for audit file (fixes #9481) by @marbens-arch in syncthing/syncthing#10066

* fix(model): loop-break regression while block copying in puller by @imsodin in syncthing/syncthing#10069

## New Contributors

* @TheCreeper made their first contribution in syncthing/syncthing#10063

**Full Changelog**: syncthing/syncthing@v2.0.0-beta.10...v2.0.0-beta.11,

----------------------------------------------------------------------------------------
retroarch.mk 92fecf68b14835715ee566f8956958df2f7d4590 # Version: Commits on Apr 24, 2025
----------------------------------------------------------------------------------------
Merge pull request #17827 from white-axe/emscripten-webgl-get-proc-address,

-----------------------------------------------------------------------------------------
libdmdutil.mk c1cd1d09b85f60f3b3d19261953bc1d9a056ea7c # Version: Commits on Apr 23, 2025
-----------------------------------------------------------------------------------------
switch to libserum_concentrate to lower memory footprint (#72),

-------------------------------------------------------------------------------------
gzdoom.mk 880ebfd94cdd0ed8536fe9a50bbae87a45bfa6a8 # Version: Commits on Apr 16, 2025
-------------------------------------------------------------------------------------
fix up header comment,

-----------------------------------------------------------------------------------
tr1x.mk 3acab0dc34c618a5e50d44afba9d85aeb1a6a634 # Version: Commits on Apr 24, 2025
-----------------------------------------------------------------------------------
tr2/ui: improve graphic settings dialog sizing

Resolves #2841.,

-----------------------------------------------------------------------------------
tr2x.mk 3acab0dc34c618a5e50d44afba9d85aeb1a6a634 # Version: Commits on Apr 24, 2025
-----------------------------------------------------------------------------------
tr2/ui: improve graphic settings dialog sizing

Resolves #2841.,

---------------------------------------------------------------------------------------------------
libretro-dosbox-pure.mk d3b7313d232156a1f60ce31749fe68e498ad3bf4 # Version: Commits on Apr 23, 2025
---------------------------------------------------------------------------------------------------
Remove DriveManager and use DOSBox Pure's disk image management even when using IMGMOUNT (#594),

------------------------------------------------------------------------------------------------------
libretro-doublecherrygb.mk ae92f5a06f3c2dac03ee72df4921fc8528981514 # Version: Commits on Apr 24, 2025
------------------------------------------------------------------------------------------------------
💚 Fix PSP BuildBot Issue,

----------------------------------------------------------------------------------------------
libretro-fceumm.mk cc4aa9950761a5896ab13420df47c774158ce7e7 # Version: Commits on Apr 23, 2025
----------------------------------------------------------------------------------------------
Add Restored Wii VC palette, original \Nintendo VC\ palette renamed to \Wii Virtual Console\ (SuperrSonic)

To avoid confusion between different Nintendo's NES color palettes (since the 3DS Virtual Console has a very different NES color palette), the palette \Nintendo Virtual Console\ was renamed to \Wii Virtual Console\, as that palette mimicks the dark color palette used by the Wii VC.

Also added a \Restored Wii VC\ palette which increases the brightness of the Wii VC NES palette to about 30%.

Credit to SuperrSonic for both palettes.,

-----------------------------------------------------------------------------------------------------
libretro-mame2003-plus.mk 04fa16be53610e5357d6996c308248f30407e65e # Version: Commits on Apr 23, 2025
-----------------------------------------------------------------------------------------------------
Updatey Mcdatety,

------------------------------------------------------------------------------------------------
libretro-nestopia.mk d2eefab298b0b9152d2934d6f0227b6803c877b3 # Version: Commits on Apr 24, 2025
------------------------------------------------------------------------------------------------
Add original Wii Virtual Console and Restored Wii VC NES palettes (SuperrSonic) (#98),

----------------------------------------------------------------------------------------------
libretro-ppsspp.mk a39eb4dc4ba05f5c7d292f7547a1502986b07e9f # Version: Commits on Apr 23, 2025
----------------------------------------------------------------------------------------------
Merge pull request #20291 from oltolm/asan

ASAN,

---------------------------------------------------------------------------------------------
libretro-vba-m.mk 4cf6cccbaf3ca80dcc85fe1b639bae4764b3d9de # Version: Commits on Apr 24, 2025
---------------------------------------------------------------------------------------------
build: bundle SFML 3.x sys/network in third_party

Remove the SFML external dependency, include the SFML 3.0.1 system and

network libraries in third_party and adjust the build code, tools and

documentation accordingly.

Signed-off-by: Rafael Kitover <rkitover@gmail.com>,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-avm1 Area: AVM1 (ActionScript 1 & 2) T-fix Type: Bug fix (in something that's supposed to work already)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants