Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rudderlabs/rudder-server
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.65.1
Choose a base ref
...
head repository: rudderlabs/rudder-server
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.65.2
Choose a head ref
  • 2 commits
  • 5 files changed
  • 2 contributors

Commits on Jan 13, 2026

  1. fix: klaviyo bulk upload manager panics after upload error (#6603) 

    🔒 Scanned for secrets using gitleaks 8.30.0

# Description

Adding a nil check in `uploadResp` in case of an error
```
level: ERROR
logger: runner.panic
caller: crash/logger.go:33
message: Panic detected. Application will crash.

panic:
runtime error: invalid memory address or nil pointer dereference

stack:
goroutine 53124 [running]:
runtime/debug.Stack()
    /usr/local/go/src/runtime/debug/stack.go:26 +0x64
github.com/rudderlabs/rudder-server/utils/crash.(*panicLogger).Notify.func1.1()
    /rudder-server/utils/crash/logger.go:35 +0x70
sync.(*Once).doSlow(0x4327b571f8?, 0x54c58?)
    /usr/local/go/src/sync/once.go:78 +0xe0
sync.(*Once).Do(...)
    /usr/local/go/src/sync/once.go:69
github.com/rudderlabs/rudder-server/utils/crash.(*panicLogger).Notify.func1()
    /rudder-server/utils/crash/logger.go:32 +0x8c
panic({0x3ae9320?, 0x76b0040?})
    /usr/local/go/src/runtime/panic.go:783 +0x120
github.com/rudderlabs/rudder-server/router/batchrouter/asyncdestinationmanager/klaviyobulkupload.(*KlaviyoBulkUploader).Upload(
    0x400920f090,
    0x40556ec5a0
)
    /rudder-server/router/batchrouter/asyncdestinationmanager/klaviyobulkupload/klaviyobulkupload.go:312 +0xc5c
github.com/rudderlabs/rudder-server/router/batchrouter.(*Handle).asyncUploadWorker(
    0x4012d76808,
    {0x4bbcb70, 0x4010647180}
)
    /rudder-server/router/batchrouter/handle_async.go:423 +0x494
github.com/rudderlabs/rudder-server/router/batchrouter.(*Handle).startAsyncDestinationManager.func2()
    /rudder-server/router/batchrouter/handle_lifecycle.go:237 +0x28
github.com/rudderlabs/rudder-server/router/batchrouter.(*Handle).startAsyncDestinationManager.Wrapper.func4()
    /rudder-server/utils/crash/default.go:36 +0x64
golang.org/x/sync/errgroup.(*Group).Go.func1()
    /go/pkg/mod/golang.org/x/sync@v0.18.0/errgroup/errgroup.go:93 +0x4c
created by golang.org/x/sync/errgroup.(*Group).Go in goroutine 6327
    /go/pkg/mod/golang.org/x/sync@v0.18.0/errgroup/errgroup.go:78 +0x90

team: Core
goRoutines: 88349
version: 1.65.1
releaseStage: production
appType: rudder-server-PROCESSOR

```

Additionally, improving async destination bug error log in case of
missing job parameters, since there seem to be a lot of occurrences for
klaviyo bulk upload.

## Security

- [x] The code changed/added as part of this pull request won't create
any security issues with how the software is being used.
    @atzoum
    atzoum authored Jan 13, 2026
    Configuration menu
    Copy the full SHA
    41ae4bb View commit details
    Browse the repository at this point in the history

  2. chore: release 1.65.2 (#6604) 

    🤖 I have created a release *beep* *boop*
---


##
[1.65.2](v1.65.1...v1.65.2)
(2026-01-13)


### Bug Fixes

* klaviyo bulk upload manager panics after upload error
([#6603](#6603))
([41ae4bb](41ae4bb))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
    @devops-github-rudderstack
    devops-github-rudderstack authored Jan 13, 2026
    Configuration menu
    Copy the full SHA
    eae5820 View commit details
    Browse the repository at this point in the history
Loading