Add tests covering "+00:00" and 0 with Time#localtime and Time.at#1285
Merged
andrykonchin merged 1 commit intoruby:masterfrom Sep 16, 2025
Merged
Add tests covering "+00:00" and 0 with Time#localtime and Time.at#1285andrykonchin merged 1 commit intoruby:masterfrom
andrykonchin merged 1 commit intoruby:masterfrom
Conversation
"+00:00" and 0 signify a zero offset that is not treated as UTC. This is similar to the existing spec for "-00:00", which is treated as UTC.
andrykonchin
approved these changes
Sep 16, 2025
Member
|
Thank you! |
philr
added a commit
to philr/jruby
that referenced
this pull request
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Time#utc?should returnfalseafter passing"+00:00"or0toTime#localtimeor as theinparameter ofTime.at.This PR adds additional test cases to cover this. These are similar to the existing test cases for
"-00:00"(whereTime#utc?should returntrue).This recently regressed in JRuby 10.0.2.0 (see jruby/jruby#8998).