Avoid autoloading openssl to try help with jruby load service issues#3809
Merged
deivid-rodriguez merged 2 commits intomasterfrom Jul 10, 2020
Merged
Avoid autoloading openssl to try help with jruby load service issues#3809deivid-rodriguez merged 2 commits intomasterfrom
openssl to try help with jruby load service issues#3809deivid-rodriguez merged 2 commits intomasterfrom
Conversation
We got an error in CI avoid this missing constant the points out again to jruby issues when autoloading and directly requiring the same thing. Avoid doing that to prevent those issues.
b31cbd1 to
e0cbc9c
Compare
openssl to try help with jruby load service issues
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 5, 2020
Avoid openssl autoload (cherry picked from commit 6082c92)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 5, 2020
Avoid openssl autoload (cherry picked from commit 6082c92)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 5, 2020
Avoid openssl autoload (cherry picked from commit 6082c92)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 6, 2020
Avoid openssl autoload (cherry picked from commit 6082c92)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 6, 2020
Avoid openssl autoload (cherry picked from commit 6082c92)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 6, 2020
Avoid openssl autoload (cherry picked from commit 6082c92)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
We got a CI failure on jruby with the following error:
It's here: https://github.com/rubygems/rubygems/runs/857727761.
What is your fix for the problem, implemented in this PR?
This most likely points to the same jruby issues we've been workarounding lately where jruby crashes with a missing constant error when you require and set an autoload for the same thing.
So, add the same workaround as in other related tickets and don't autoload
openssl.This is code inside
net-http-persistent, so adding a note too about why we're doing this.This is a follow up to #3751, #3770, #3771, and #3781.
Tasks:
I will abide by the code of conduct.