Merged
Conversation
Contributor
|
Thanks! @bundlerbot r+ |
Contributor
|
📌 Commit e093fb7 has been approved by |
Contributor
bundlerbot
added a commit
that referenced
this pull request
Feb 18, 2018
Add missing requires # Description: I'm getting some crashes when running tests for my gem: https://circleci.com/gh/decidim/decidim/54469. Adding the missing requires that the error points to seems to fix them. The require in `dependency.rb` comes from the error message, the second require comes from the error message that still appears after adding the first require. I tried to isolate this, but I couldn't. So the minimal reproduction would be: ``` git clone https://github.com/decidim/decidim cd decidim git checkout rails-5.1.5-and-pg-1.0 bundle install bundle exec rspec spec/generator_spec.rb[1:1:1:1] ``` # Tasks: - [x] Describe the problem / feature - [ ] Write tests - [x] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
Contributor
|
☀️ Test successful - status-travis |
Contributor
Author
|
Thanks to you! :) |
hsbt
pushed a commit
that referenced
this pull request
Apr 28, 2018
Add missing requires I'm getting some crashes when running tests for my gem: https://circleci.com/gh/decidim/decidim/54469. Adding the missing requires that the error points to seems to fix them. The require in `dependency.rb` comes from the error message, the second require comes from the error message that still appears after adding the first require. I tried to isolate this, but I couldn't. So the minimal reproduction would be: ``` git clone https://github.com/decidim/decidim cd decidim git checkout rails-5.1.5-and-pg-1.0 bundle install bundle exec rspec spec/generator_spec.rb[1:1:1:1] ``` - [x] Describe the problem / feature - [ ] Write tests - [x] Write code to solve the problem - [ ] Get code review from coworkers / friends I will abide by the [code of conduct](https://github.com/rubygems/rubygems/blob/master/CODE_OF_CONDUCT.md).
lamont-granquist
added a commit
to chef/appbundler
that referenced
this pull request
May 2, 2018
in at least rubygems 2.7.6 when two chef gems are installed (as an example, but i think the problem is generalized to other gems with two installed versions, but it repros nicely with two chef gems), instead of pinning a version a bundler bug makes us explode with /opt/chefdk/embedded/lib/ruby/site_ruby/2.4.0/rubygems/dependency.rb:284:in `matching_specs': uninitialized constant Gem::BundlerVersionFinder (NameError) which is ruby/rubygems#2196 this works around the bug by doing the require here, protected with exception handling to not blow up on rubygems versions that don't have this class. once 2.7.7 / 2.8.0 is released this code should probably be deleted (at the same time the exception means it shouldn't hurt anything). Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
I'm getting some crashes when running tests for my gem: https://circleci.com/gh/decidim/decidim/54469.
Adding the missing requires that the error points to seems to fix them. The require in
dependency.rbcomes from the error message, the second require comes from the error message that still appears after adding the first require.I tried to isolate this, but I couldn't. So the minimal reproduction would be:
Tasks:
I will abide by the code of conduct.