Introduce IO.new(..., path:) and promote File#path to IO#path.#6867
Merged
ioquatix merged 6 commits intoruby:masterfrom Dec 8, 2022
Merged
Introduce IO.new(..., path:) and promote File#path to IO#path.#6867ioquatix merged 6 commits intoruby:masterfrom
IO.new(..., path:) and promote File#path to IO#path.#6867ioquatix merged 6 commits intoruby:masterfrom
Conversation
Contributor
|
Looks good to me but shouldn't rb_file_path remain as an alias for rb_io_path? |
Contributor
rb_file_path is not in any of the public header files, so it is not part of the public API and does not need to remain. |
Member
Author
|
I'm going to merge this as is, but:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current semantics for
File#pathare at best difficult to deal with.#path.I've chosen to make this behave more like an attribute in
IO#pathwhich should ultimately be compatible with existing code except it can no longer raise an exception in normal usage.https://bugs.ruby-lang.org/issues/19036