YJIT: Support Rust 1.58.1 for --yjit-stats on Arm#6410
Merged
maximecb merged 8 commits intoruby:masterfrom Sep 23, 2022
Merged
Conversation
0aeed2d to
7b5aa14
Compare
5eb5f86 to
6b8daf6
Compare
for checking it properly
4cc2b99 to
3a524f6
Compare
maximecb
reviewed
Sep 22, 2022
Member
|
|
Contributor
That would definitely be simpler if it works. I like that this PR sets the default toolchain on Cirrus CI to 1.58.1 though, we should definitely keep that. |
cc448f4 to
36268de
Compare
36268de to
4e2a9ca
Compare
Member
Author
|
I tried Alan's idea 4e2a9ca, but CI seems to say it doesn't work if how I used it was right. I took Maxime's idea #6410 (comment) instead. It seems fine on my M1 laptop, but I'll need to see if CI succeeds with this. |
maximecb
reviewed
Sep 23, 2022
maximecb
reviewed
Sep 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows up #6401 and #6409.
I updated Cirrus to test Rust 1.58.1 for the --enable-yjit=dev job and fixed its build failure. As we're on Rust 1.58.1, using autoconf seems to be the simplest solution that I've found so far.