Guard --yjit-stats behind #[cfg(feature = "stats")]#6409
Merged
maximecb merged 5 commits intoruby:masterfrom Sep 20, 2022
Merged
Guard --yjit-stats behind #[cfg(feature = "stats")]#6409maximecb merged 5 commits intoruby:masterfrom
--yjit-stats behind #[cfg(feature = "stats")]#6409maximecb merged 5 commits intoruby:masterfrom
Conversation
XrXr
approved these changes
Sep 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@eileencodes ran into an issue where
std::arch::is_aarch64_feature_detected!("lse")is not supported by rust 1.59, and so compilation fails.More broadly, maybe we should check that we can at least compile with Rust 1.58.1 on the arm64 CI, but in the mean time, guarding this behind the stats feature should make it so that YJIT will build in release mode on those older Rust versions.