Improve efficiency of drb ID hash using reference queues#2104
Open
headius wants to merge 4 commits intoruby:masterfrom
Open
Improve efficiency of drb ID hash using reference queues#2104headius wants to merge 4 commits intoruby:masterfrom
headius wants to merge 4 commits intoruby:masterfrom
Conversation
This implementation must periodically "clean" stale references out of the underlying Hash, which requires an O(n) search. To reduce the chance of this search happening, it only runs when inserting a new entry into the weak mapping. Stale entries that are discovered while retrieving entries are deleted individually.
This version requires the "weakling" library, for its implementation of weak reference queues. It improves on the weakref-only implementation by reducing the periodic reference scan to a queue poll, which should be a no-op when there are no queued references. In order for this implementation to work in CRuby, the weakref library would need to support reference queues, ideally backed by the CRuby GC to make them efficient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on #2102, which is for https://bugs.ruby-lang.org/issues/15711.
This version requires the "weakling" library, for its
implementation of weak reference queues. It improves on the
weakref-only implementation by reducing the periodic reference
scan to a queue poll, which should be a no-op when there are no
queued references.
In order for this implementation to work in CRuby, the weakref
library would need to support reference queues, ideally backed by
the CRuby GC to make them efficient.