Handle prism on_sp in syntax_suggest#15914
Merged
eregon merged 2 commits intoruby:masterfrom Jan 20, 2026
Merged
Conversation
It used to not emit this token type, but now it does. So when a newer version of prism is present, we can fall back to the same code that ripper uses.
…nd Prism::Translation::Ripper" This reverts commit 58f1127.
syntax_suggeston_sp in syntax_suggest
|
The following files are maintained in the following upstream repositories:
Please file a pull request to the above instead. Thank you! |
Earlopain
added a commit
to Earlopain/syntax_suggest
that referenced
this pull request
Jan 20, 2026
It used to not emit this token type, but now it does. So when a newer version of prism is present, we can fall back to the same code that ripper uses. Ref: * ruby/ruby#15914 * ruby/prism#3859
Earlopain
added a commit
to Earlopain/syntax_suggest
that referenced
this pull request
Jan 20, 2026
It used to not emit this token type, but now it does. So when a newer version of prism is present, we can fall back to the same code that ripper uses. Ref: * ruby/ruby#15914 * ruby/prism#3859
Earlopain
added a commit
to Earlopain/syntax_suggest
that referenced
this pull request
Jan 20, 2026
It used to not emit this token type, but now it does. So when a newer version of prism is present, we can fall back to the same code that ripper uses. Ref: * ruby/ruby#15914 * ruby/prism#3859
bb435a4 to
d98ea1a
Compare
Contributor
Author
|
@kddnewton could you take a look? I also created ruby/syntax_suggest#241 for |
eregon
approved these changes
Jan 20, 2026
Earlopain
added a commit
to Earlopain/syntax_suggest
that referenced
this pull request
Jan 20, 2026
It used to not emit this token type, but now it does. So when a newer version of prism is present, we can fall back to the same code that ripper uses. Ref: * ruby/ruby#15914 * ruby/prism#3859
Earlopain
added a commit
to Earlopain/syntax_suggest
that referenced
this pull request
Jan 20, 2026
It used to not emit this token type, but now it does. So when a newer version of prism is present, we can fall back to the same code that ripper uses. Ref: * ruby/ruby#15914 * ruby/prism#3859
schneems
pushed a commit
to ruby/syntax_suggest
that referenced
this pull request
Jan 20, 2026
It used to not emit this token type, but now it does. So when a newer version of prism is present, we can fall back to the same code that ripper uses. Ref: * ruby/ruby#15914 * ruby/prism#3859
Earlopain
added a commit
to Earlopain/ruby
that referenced
this pull request
Jan 21, 2026
It used to not emit this token type, but now it does. So when a newer version of prism is present, we can fall back to the same code that ripper uses. Ref: * ruby#15914 * ruby/prism#3859 ruby/syntax_suggest@42a3b8f6cb
Earlopain
added a commit
to Earlopain/ruby
that referenced
this pull request
Jan 21, 2026
It used to not emit this token type, but now it does. So when a newer version of prism is present, we can fall back to the same code that ripper uses. Ref: * ruby#15914 * ruby/prism#3859 ruby/syntax_suggest@42a3b8f6cb
Earlopain
added a commit
to Earlopain/ruby
that referenced
this pull request
Jan 21, 2026
It used to not emit this token type, but now it does. So when a newer version of prism is present, we can fall back to the same code that ripper uses. Ref: * ruby#15914 * ruby/prism#3859 ruby/syntax_suggest@42a3b8f6cb
k0kubun
pushed a commit
that referenced
this pull request
Jan 21, 2026
It used to not emit this token type, but now it does. So when a newer version of prism is present, we can fall back to the same code that ripper uses. Ref: * #15914 * ruby/prism#3859 ruby/syntax_suggest@42a3b8f6cb
hsbt
pushed a commit
that referenced
this pull request
Mar 23, 2026
It used to not emit this token type, but now it does. So when a newer version of prism is present, we can fall back to the same code that ripper uses. Ref: * #15914 * ruby/prism#3859 ruby/syntax_suggest@42a3b8f6cb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle
on_spinsyntax_suggestwhen using prism.It used to not emit this token type, but now it does. So when a newer version of prism is present, we can fall back to the same code that ripper uses.