ZJIT: Inline BasicObject#initialize#14856
Merged
tekknolagi merged 1 commit intoruby:masterfrom Oct 16, 2025
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
7b91b3c to
3d4f929
Compare
It just returns nil.
3d4f929 to
7ecb6c8
Compare
XrXr
approved these changes
Oct 16, 2025
| PatchPoint MethodRedefined(Object@0x1008, initialize@0x1040, cme:0x1048) | ||
| PatchPoint NoSingletonClass(Object@0x1008) | ||
| v47:NilClass = CCall initialize@0x1070, v43 | ||
| v47:NilClass = Const Value(nil) |
Member
There was a problem hiding this comment.
OT: It's weird that this isn't DCE'd, since the return value of initialize is not semantically used. I guess it got caught in a FrameState somehow.
Contributor
Author
There was a problem hiding this comment.
Yep, that happens a lot more now with the aggressive patchpointing and checkinterrupts. It would have gotten DCEd as the CCall too since it's marked elidable. Long-term I would like to fix this :/
aidenfoxivey
pushed a commit
to aidenfoxivey/ruby
that referenced
this pull request
Oct 17, 2025
It just returns nil.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It just returns nil.