YJIT: Add more information to an assert message in jit_guard_known_class#14480
Merged
k0kubun merged 2 commits intoruby:masterfrom Sep 8, 2025
Merged
YJIT: Add more information to an assert message in jit_guard_known_class#14480k0kubun merged 2 commits intoruby:masterfrom
k0kubun merged 2 commits intoruby:masterfrom
Conversation
in jit_guard_known_class
XrXr
approved these changes
Sep 8, 2025
st0012
approved these changes
Sep 8, 2025
Co-authored-by: Alan Wu <XrXr@users.noreply.github.com>
k0kubun
added a commit
to k0kubun/ruby
that referenced
this pull request
Sep 8, 2025
…ass (ruby#14480) * YJIT: Add more information to an assert message in jit_guard_known_class * Say "should be a heap object" instead Co-authored-by: Alan Wu <XrXr@users.noreply.github.com> --------- Co-authored-by: Alan Wu <XrXr@users.noreply.github.com>
k0kubun
added a commit
that referenced
this pull request
Sep 8, 2025
YJIT: Add more information to an assert message in jit_guard_known_class (#14480) --------- Co-authored-by: Alan Wu <XrXr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates an assertion failure message to help us debug https://bugs.ruby-lang.org/issues/21565 further.
It seems like a compile-time
sample_instanceand theContextdon't agree on each other. To see what's happening, I want to print bothsample_instance(likely just a random pointer, but I just want to make sure it's not an immediate we don't handle) and theval_typein theContext.To ensure the consistency between
known_klassandsample_instance, I refactored it to extractknown_klassfromsample_instanceas well.