No numbered parameters in Binding#local_variables#12746
Merged
mame merged 3 commits intoruby:masterfrom Feb 18, 2025
Merged
Conversation
✅ All Tests passed!✖️no tests failed ✔️61616 tests passed(3 flakes) |
4d9e898 to
d780f74
Compare
... instead of "rb_env_t **" because no one uses the updated env.
d780f74 to
9df39ba
Compare
nobu
reviewed
Feb 18, 2025
nobu
reviewed
Feb 18, 2025
Also, Binding#local_variable_get and #local_variable_set rejects an access to numbered parameters. [Bug #20965] [Bug #21049]
9df39ba to
d857602
Compare
Member
|
FYI this PR seems the likely cause of this error in debug builds: https://github.com/DataDog/ruby-dev-builder/actions/runs/13386925511/job/37385688980 There is also an ASAN error for it if useful: https://github.com/DataDog/ruby-dev-builder/actions/runs/13386925511/job/37385695242 |
Member
|
BTW doesn't ruby/ruby CI run test-all with |
headius
added a commit
to headius/jruby
that referenced
this pull request
Nov 18, 2025
For Ruby 4.0 compatibility. See ruby/ruby#12746 See jruby#9061
headius
added a commit
to headius/jruby
that referenced
this pull request
Jan 28, 2026
For Ruby 4.0 compatibility. See ruby/ruby#12746 See jruby#9061
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.ruby-lang.org/issues/21049