Revert the change to fix duplicate responses on Linux#7
Closed
jeremyevans wants to merge 2 commits intoruby:masterfrom
Closed
Revert the change to fix duplicate responses on Linux#7jeremyevans wants to merge 2 commits intoruby:masterfrom
jeremyevans wants to merge 2 commits intoruby:masterfrom
Conversation
Linux seems to have a bug where resolving an invalid domain hangs until the socket times out. This doesn't appear to affect other operating systems. The timeouts for invalid domains are definitely worse than improper handling of duplicate responses, so revert the code on Linux but keep it on other operating systems that do not have the timeout issue.
The skip method doesn't exist.
casperisfine
pushed a commit
to Shopify/ruby
that referenced
this pull request
Mar 25, 2021
Contributor
Author
|
This is better fixed by #9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linux seems to have a bug where resolving an invalid domain hangs
until the socket times out. This doesn't appear to affect other
operating systems. The timeouts for invalid domains are definitely
worse than improper handling of duplicate responses, so revert the
code on Linux but keep it on other operating systems that do not
have the timeout issue.