Clear flags on interpolated strings#3606
Merged
tenderlove merged 1 commit intoruby:mainfrom Jul 21, 2025
Merged
Conversation
st0012
reviewed
Jul 21, 2025
When inner strings aren't frozen, we need to clear the flags on interpolated string nodes so that we don't emit wrong instructions. The compiler is currently incorrectly emitting frozen strings because the parser is erroneously declaring interpolated strings as "frozen". We need to fix this behavior in the parser so we can fix the compiler in CRuby. This patch is a partial fix for [this bug](https://bugs.ruby-lang.org/issues/21187)
st0012
approved these changes
Jul 21, 2025
vinistock
approved these changes
Jul 21, 2025
tenderlove
added a commit
to tenderlove/ruby
that referenced
this pull request
Jul 22, 2025
Strings concatenated with backslash may end up being frozen when they shouldn't be. This commit fixes the issue. It required a change upstream in Prism, but also a change to the Prism compiler in CRuby. ruby/prism#3606 [Bug #21187]
tenderlove
added a commit
to tenderlove/ruby
that referenced
this pull request
Jul 22, 2025
Strings concatenated with backslash may end up being frozen when they shouldn't be. This commit fixes the issue. It required a change upstream in Prism, but also a change to the Prism compiler in CRuby. ruby/prism#3606 [Bug #21187]
tenderlove
added a commit
to ruby/ruby
that referenced
this pull request
Jul 22, 2025
Strings concatenated with backslash may end up being frozen when they shouldn't be. This commit fixes the issue. It required a change upstream in Prism, but also a change to the Prism compiler in CRuby. ruby/prism#3606 [Bug #21187]
k0kubun
pushed a commit
to k0kubun/ruby
that referenced
this pull request
Dec 8, 2025
Strings concatenated with backslash may end up being frozen when they shouldn't be. This commit fixes the issue. It required a change upstream in Prism, but also a change to the Prism compiler in CRuby. ruby/prism#3606 [Bug #21187]
k0kubun
pushed a commit
to k0kubun/ruby
that referenced
this pull request
Dec 8, 2025
Strings concatenated with backslash may end up being frozen when they shouldn't be. This commit fixes the issue. It required a change upstream in Prism, but also a change to the Prism compiler in CRuby. ruby/prism#3606 [Bug #21187]
k0kubun
pushed a commit
to ruby/ruby
that referenced
this pull request
Dec 8, 2025
Strings concatenated with backslash may end up being frozen when they shouldn't be. This commit fixes the issue. It required a change upstream in Prism, but also a change to the Prism compiler in CRuby. ruby/prism#3606 [Bug #21187]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When inner strings aren't frozen, we need to clear the flags on interpolated string nodes so that we don't emit wrong instructions.
The compiler is currently incorrectly emitting frozen strings because the parser is erroneously declaring interpolated strings as "frozen". We need to fix this behavior in the parser so we can fix the compiler in CRuby. This patch is a partial fix for this bug