Make tests pass on LibreSSL 3.5 and 3.4#506
Merged
jeremyevans merged 4 commits intoruby:masterfrom Apr 1, 2022
Merged
Conversation
LibreSSL 3.5 switched the cipher naming to match OpenSSL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The openssl extension stopped building on LibreSSL 3.5. #499 attempts
to address this, but also includes some new features. This pull request
is strictly limited to fixing bugs.
While trying to get tests to pass, I noticed OSSL_OPENSSL_PREREQ and
OSSL_LIBRESSL_PREREQ were broken due to operator precedence issues,
so this fixes those.
The remaining fix was a small test fix to allow tests to pass on LibreSSL 3.4,
due to a non-standard cipher name (changed to match OpenSSL in
LibreSSL 3.5).