LibreSSL 3.5.0 has PEM_write_bio_PrivateKey_traditional#499
Closed
vishwin wants to merge 4 commits intoruby:maint-3.0from
Closed
LibreSSL 3.5.0 has PEM_write_bio_PrivateKey_traditional#499vishwin wants to merge 4 commits intoruby:maint-3.0from
vishwin wants to merge 4 commits intoruby:maint-3.0from
Conversation
…along with some unit tests (ruby#493) Add OpenSSL::SSL::SSLContext#ciphersuites= method along with unit tests.
I use ruby.git's tool/sync_default_gems.rb and simple git cherry-pick instead nowadays. These tasks actually don't correctly work because they use outdated path references and expect ruby.git to be using git-svn, which is not the case anymore. Reported-by: rkoster <hi@rkoster.dev> Fixes: ruby#495
Member
|
Thank you for reporting & the patch! So, the extension currently doesn't compile because EVP_PKEY is an opaque struct in LibreSSL 3.5.0, just like in OpenSSL 1.1.0. 56f0d34 introduced the current code, which was first released as |
rhenium
reviewed
Mar 2, 2022
| (void *)pass)) { | ||
| #else | ||
| #if OPENSSL_VERSION_NUMBER < 0x10100000 || \ | ||
| (defined(LIBRESSL_VERSION_NUMBER) && LIBRESSL_VERSION_NUMBER < 0x30500000) |
Member
There was a problem hiding this comment.
We can now use OSSL_OPENSSL_PREREQ() and OSSL_LIBRESSL_PREREQ() macro.
Member
|
The change has been merged by #506. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the one symbol that currently causes the build to fail when using LibreSSL 3.5.0. They have otherwise added a lot more symbols in this version.
While here, update CI for current LibreSSL versions.