Merged
Conversation
added 12 commits
October 28, 2014 17:51
use ruby-lang.org.
Member
|
👍 |
rhenium
added a commit
to rhenium/ruby-openssl
that referenced
this pull request
Jul 8, 2016
Currently they return XXXPrivateKey format (PKCS ruby#1 RSAPrivateKey for RSA, OpenSSL's original format for DSA, anad SEC 1 ECPrivateKey for EC) when the instance contains the private portion, or PUBKEY format (SubjectPublicKeyInfo) otherwise. There is no option to force the format, so users need to duplicate the key first and remove the private key. This resolves it by adding :format keyword argument to PKey::PKey#to_{der,pem}. Users can pass either :PrivateKey or :PUBKEY.
rhenium
added a commit
to rhenium/ruby-openssl
that referenced
this pull request
Jul 9, 2016
Currently they return XXXPrivateKey format (PKCS ruby#1 RSAPrivateKey for RSA, OpenSSL's original format for DSA, anad SEC 1 ECPrivateKey for EC) when the instance contains the private portion, or PUBKEY format (SubjectPublicKeyInfo) otherwise. There is no option to force the format, so users need to duplicate the key first and remove the private key. This resolves it by adding :format keyword argument to PKey::PKey#to_{der,pem}. Users can pass either :PrivateKey or :PUBKEY.
rhenium
added a commit
to rhenium/ruby-openssl
that referenced
this pull request
Jul 10, 2016
Currently they return XXXPrivateKey format (PKCS ruby#1 RSAPrivateKey for RSA, OpenSSL format for DSA, anad SEC 1 ECPrivateKey for EC) when the instance contains the private key, or SubjectPublicKeyInfo) otherwise. There is no option to force the format, so users need to duplicate the key first and remove the private key if they want SubjectPublicKeyInfo DER from a key. This resolves it by adding :format keyword argument to PKey::PKey#to_{der,pem}. Users can pass either :*PrivateKey or :SubjectPublicKeyInfo.
rhenium
pushed a commit
to rhenium/ruby-openssl
that referenced
this pull request
Aug 17, 2016
Update packages
bdewater
added a commit
to bdewater/openssl
that referenced
this pull request
Oct 8, 2022
bdewater
added a commit
to bdewater/openssl
that referenced
this pull request
Oct 8, 2022
rhenium
added a commit
that referenced
this pull request
Oct 17, 2022
Call out insecure PKCS #1 v1.5 default padding for RSA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's some work to update with travis ci, and sync a patch from trunk