Skip to content

Clear ENV["XDG_CONFIG_HOME"] to avoid loading user-defined irbrc in test#982

Merged
tompng merged 1 commit intoruby:masterfrom
tompng:test_clear_xdg_env
Jul 18, 2024
Merged

Clear ENV["XDG_CONFIG_HOME"] to avoid loading user-defined irbrc in test#982
tompng merged 1 commit intoruby:masterfrom
tompng:test_clear_xdg_env

Conversation

@tompng
Copy link
Member

@tompng tompng commented Jul 17, 2024

TestIRB::ConfigValidationTest#setup forgot to clear ENV['XDG_CONFIG_HOME']

With these environment variables, rake test fails.

echo "puts 'IRBRC'; exit" > /path/to/dummy_home/env_irbrc
echo "puts 'HOME'; exit" > /path/to/dummy_home/.irbrc
echo "puts 'XDG'; exit" > /path/to/dummy_home/.config/irb/irbrc
IRBRC=/path/to/dummy_home/env_irbrc HOME=/path/to/dummy_home/ XDG_CONFIG_HOME=/path/to/dummy_home/.config rake test

Test passes with normal irbrc content maybe with Error loading RC file warning message, but it's better not to read user-defined irbrc file.

olleolleolle
olleolleolle reviewed Jul 18, 2024
View reviewed changes
@tompng tompng force-pushed the test_clear_xdg_env branch from 6113d5e to 90b4bfa Compare July 18, 2024 10:20
@tompng tompng merged commit 632da0f into ruby:master Jul 18, 2024
@tompng tompng deleted the test_clear_xdg_env branch July 18, 2024 10:56
matzbot pushed a commit to ruby/ruby that referenced this pull request Jul 18, 2024
@tompng @matzbot
[ruby/irb] Clear ENV["XDG_CONFIG_HOME"] to avoid loading
c304bf1 
user-defined irbrc in TestIRB::ConfigValidationTest
(ruby/irb#982)

ruby/irb@632da0ff29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@st0012 st0012 st0012 approved these changes

+1 more reviewer

@olleolleolle olleolleolle olleolleolle left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tompng @olleolleolle @st0012